From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 8DF9F1FF16F
for <inbox@lore.proxmox.com>; Thu, 27 Feb 2025 15:35:02 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 3188A29A3E;
Thu, 27 Feb 2025 15:35:01 +0100 (CET)
Message-ID: <82f15b5e-9c2b-4925-a3f1-bb5180486975@proxmox.com>
Date: Thu, 27 Feb 2025 15:34:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20250116163055.2619572-1-a.lauterer@proxmox.com>
In-Reply-To: <20250116163055.2619572-1-a.lauterer@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.033 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager] pvestatd: improve broadcast of node
version-info
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
sent a v2
https://lore.proxmox.com/pve-devel/20250227143356.1089350-1-a.lauterer@proxmox.com/T/#u
On 2025-01-16 17:30, Aaron Lauterer wrote:
> Until now, the pvestatd did broadcast the pve-manager version only once
> after startup of the service. But there are some situations, where the
> local pmxcfs (pve-cluster) restarts and loses that information.
> Basically everytime we restart the pmxcfs without restarting pvestatd
> too.
>
> For example, on a cluster join, or if the pmxcfs has been restarted
> manually.
>
> By additionally checking if the local kv-store of the pmxcfs has any
> version info for the node, we can decide if another broadcast is
> necessary.
> Therefore after the next run of pvestatd, we should have the full
> version info available again.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> This patch is preparation to get reliable version infos as I am picking
> of the patch series of Folke to include more metrics into the RRD data
> and summary graphs. [0]
> This was a big blocker and now with the major version change coming up,
> we at least can assume the latest 8.x installed as part of the update to
> PVE 9.
> Therefore, we should get this in with PVE 8. Additional patches for PVE
> 8 will follow to make the transition smoother. But as mentioned, this
> here is one of the things that needs to work reliably, which is why I
> submit the patch already now.
>
> [0] https://lore.proxmox.com/pve-devel/20231211144721.212071-1-f.gleumes@proxmox.com/
>
> PVE/Service/pvestatd.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
> index 7fa003fe..03c578e1 100755
> --- a/PVE/Service/pvestatd.pm
> +++ b/PVE/Service/pvestatd.pm
> @@ -527,7 +527,10 @@ sub update_sdn_status {
>
> my $broadcast_version_info_done = 0;
> my sub broadcast_version_info : prototype() {
> - if (!$broadcast_version_info_done) {
> + if (
> + !$broadcast_version_info_done
> + || !keys PVE::Cluster::get_node_kv('version-info', $nodename)->%*
> + ) {
> PVE::Cluster::broadcast_node_kv(
> 'version-info',
> encode_json(PVE::pvecfg::version_info()),
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel