From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 40FE61FF164 for ; Fri, 6 Dec 2024 10:17:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B9BD833; Fri, 6 Dec 2024 10:17:27 +0100 (CET) Message-ID: <82b77900-7239-4cc9-863a-0a3a3ddff5c6@proxmox.com> Date: Fri, 6 Dec 2024 10:17:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Gabriel Goller , pve-devel@lists.proxmox.com References: <20241205151033.506549-1-g.goller@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <20241205151033.506549-1-g.goller@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 1/2] log: add perlmod logger and custom formatter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2024-12-05 16:10, Gabriel Goller wrote: > Add special logger for perlmod. This one will print everything to > stderr (which will end up in the tasklog) and the errors to journald. > This also includes a custom formatter so that the stderr output will > look like: "INFO: sample message". > > Reported-by: Maximiliano Sandoval > Reported-by: Lukas Wagner > Signed-off-by: Gabriel Goller > --- > > I didn't include Lukas's T-b as I changed quite a lot on this > patch. > Gave v3 another quick spin, seems to work as advertised. Code also looks good to me, though I have to say that I don't know much about the tracing ecosystem. Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner Maybe another set of eyes would be good, as I'm not sure if I'm overlooking some issue regarding 'always logging to stderr' part in non-task context. -- - Lukas _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel