From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 4412D1FF183
for <inbox@lore.proxmox.com>; Wed, 21 May 2025 13:28:28 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 8989716825;
Wed, 21 May 2025 13:28:28 +0200 (CEST)
Message-ID: <81df0520-361b-44c4-8b22-9499723e9cca@proxmox.com>
Date: Wed, 21 May 2025 13:27:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: pve-devel@lists.proxmox.com
References: <20250519125959.7189-1-s.shaji@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20250519125959.7189-1-s.shaji@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.021 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] chore: assets: update
flutter app icons in iOS with proxmox icons
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
while i can't test the changes for ios, the images look good,
one question for my curiosity:
what triggered the changes in the Contents.json ?
AFAICS it's just reordering the properties + whitespace changes, which
make it hard to see if there was any actual change to the content...
not that I'm against it, but we should probably not unnecessarily touch these files,
except some tooling (e.g. from flutter) autoformats these or there
are real changes...
On 5/19/25 14:59, Shan Shaji wrote:
> When running the app in iOS the app icon was the default flutter
> icon and this commit fixes it by replacing all
> flutter icons with the proxmox app icon.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
> .../AppIcon.appiconset/Contents.json | 160 +++++++++---------
> .../Icon-App-1024x1024@1x.png | Bin 10932 -> 126022 bytes
> .../AppIcon.appiconset/Icon-App-20x20@1x.png | Bin 295 -> 692 bytes
> .../AppIcon.appiconset/Icon-App-20x20@2x.png | Bin 406 -> 2050 bytes
> .../AppIcon.appiconset/Icon-App-20x20@3x.png | Bin 450 -> 3321 bytes
> .../AppIcon.appiconset/Icon-App-29x29@1x.png | Bin 282 -> 1425 bytes
> .../AppIcon.appiconset/Icon-App-29x29@2x.png | Bin 462 -> 3367 bytes
> .../AppIcon.appiconset/Icon-App-29x29@3x.png | Bin 704 -> 5147 bytes
> .../AppIcon.appiconset/Icon-App-40x40@1x.png | Bin 406 -> 2050 bytes
> .../AppIcon.appiconset/Icon-App-40x40@2x.png | Bin 586 -> 4699 bytes
> .../AppIcon.appiconset/Icon-App-40x40@3x.png | Bin 862 -> 7470 bytes
> .../AppIcon.appiconset/Icon-App-60x60@2x.png | Bin 862 -> 7470 bytes
> .../AppIcon.appiconset/Icon-App-60x60@3x.png | Bin 1674 -> 11744 bytes
> .../AppIcon.appiconset/Icon-App-76x76@1x.png | Bin 762 -> 4378 bytes
> .../AppIcon.appiconset/Icon-App-76x76@2x.png | Bin 1226 -> 9529 bytes
> .../Icon-App-83.5x83.5@2x.png | Bin 1418 -> 11072 bytes
> 16 files changed, 80 insertions(+), 80 deletions(-)
> mode change 100644 => 100755 ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
>
> diff --git a/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json b/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
> old mode 100644
> new mode 100755
> index d36b1fa..9b6d103
> --- a/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
> +++ b/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
> @@ -1,122 +1,122 @@
> {
> - "images" : [
> + "images": [
> {
> - "size" : "20x20",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-20x20@2x.png",
> - "scale" : "2x"
> + "idiom": "iphone",
> + "size": "20x20",
> + "scale": "2x",
> + "filename": "Icon-App-20x20@2x.png"
> },
> {
> - "size" : "20x20",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-20x20@3x.png",
> - "scale" : "3x"
> + "idiom": "iphone",
> + "size": "20x20",
> + "scale": "3x",
> + "filename": "Icon-App-20x20@3x.png"
> },
> {
> - "size" : "29x29",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-29x29@1x.png",
> - "scale" : "1x"
> + "idiom": "iphone",
> + "size": "29x29",
> + "scale": "1x",
> + "filename": "Icon-App-29x29@1x.png"
> },
> {
> - "size" : "29x29",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-29x29@2x.png",
> - "scale" : "2x"
> + "idiom": "iphone",
> + "size": "29x29",
> + "scale": "2x",
> + "filename": "Icon-App-29x29@2x.png"
> },
> {
> - "size" : "29x29",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-29x29@3x.png",
> - "scale" : "3x"
> + "idiom": "iphone",
> + "size": "29x29",
> + "scale": "3x",
> + "filename": "Icon-App-29x29@3x.png"
> },
> {
> - "size" : "40x40",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-40x40@2x.png",
> - "scale" : "2x"
> + "idiom": "iphone",
> + "size": "40x40",
> + "scale": "2x",
> + "filename": "Icon-App-40x40@2x.png"
> },
> {
> - "size" : "40x40",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-40x40@3x.png",
> - "scale" : "3x"
> + "idiom": "iphone",
> + "size": "40x40",
> + "scale": "3x",
> + "filename": "Icon-App-40x40@3x.png"
> },
> {
> - "size" : "60x60",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-60x60@2x.png",
> - "scale" : "2x"
> + "idiom": "iphone",
> + "size": "60x60",
> + "scale": "2x",
> + "filename": "Icon-App-60x60@2x.png"
> },
> {
> - "size" : "60x60",
> - "idiom" : "iphone",
> - "filename" : "Icon-App-60x60@3x.png",
> - "scale" : "3x"
> + "idiom": "iphone",
> + "size": "60x60",
> + "scale": "3x",
> + "filename": "Icon-App-60x60@3x.png"
> },
> {
> - "size" : "20x20",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-20x20@1x.png",
> - "scale" : "1x"
> + "idiom": "ipad",
> + "size": "20x20",
> + "scale": "1x",
> + "filename": "Icon-App-20x20@1x.png"
> },
> {
> - "size" : "20x20",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-20x20@2x.png",
> - "scale" : "2x"
> + "idiom": "ipad",
> + "size": "20x20",
> + "scale": "2x",
> + "filename": "Icon-App-20x20@2x.png"
> },
> {
> - "size" : "29x29",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-29x29@1x.png",
> - "scale" : "1x"
> + "idiom": "ipad",
> + "size": "29x29",
> + "scale": "1x",
> + "filename": "Icon-App-29x29@1x.png"
> },
> {
> - "size" : "29x29",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-29x29@2x.png",
> - "scale" : "2x"
> + "idiom": "ipad",
> + "size": "29x29",
> + "scale": "2x",
> + "filename": "Icon-App-29x29@2x.png"
> },
> {
> - "size" : "40x40",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-40x40@1x.png",
> - "scale" : "1x"
> + "idiom": "ipad",
> + "size": "40x40",
> + "scale": "1x",
> + "filename": "Icon-App-40x40@1x.png"
> },
> {
> - "size" : "40x40",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-40x40@2x.png",
> - "scale" : "2x"
> + "idiom": "ipad",
> + "size": "40x40",
> + "scale": "2x",
> + "filename": "Icon-App-40x40@2x.png"
> },
> {
> - "size" : "76x76",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-76x76@1x.png",
> - "scale" : "1x"
> + "idiom": "ipad",
> + "size": "76x76",
> + "scale": "1x",
> + "filename": "Icon-App-76x76@1x.png"
> },
> {
> - "size" : "76x76",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-76x76@2x.png",
> - "scale" : "2x"
> + "idiom": "ipad",
> + "size": "76x76",
> + "scale": "2x",
> + "filename": "Icon-App-76x76@2x.png"
> },
> {
> - "size" : "83.5x83.5",
> - "idiom" : "ipad",
> - "filename" : "Icon-App-83.5x83.5@2x.png",
> - "scale" : "2x"
> + "idiom": "ipad",
> + "size": "83.5x83.5",
> + "scale": "2x",
> + "filename": "Icon-App-83.5x83.5@2x.png"
> },
> {
> - "size" : "1024x1024",
> - "idiom" : "ios-marketing",
> - "filename" : "Icon-App-1024x1024@1x.png",
> - "scale" : "1x"
> + "size": "1024x1024",
> + "idiom": "ios-marketing",
> + "scale": "1x",
> + "filename": "Icon-App-1024x1024@1x.png"
> }
> ],
> - "info" : {
> - "version" : 1,
> - "author" : "xcode"
> + "info": {
> + "version": 1,
> + "author": "xcode"
> }
> }
[snipped all the binary diffs]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel