From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 719029D0D for ; Wed, 6 Sep 2023 11:19:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5081531C42 for ; Wed, 6 Sep 2023 11:18:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Sep 2023 11:18:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7A07642895 for ; Wed, 6 Sep 2023 11:18:35 +0200 (CEST) Message-ID: <8144f930-078c-4ea4-911e-5932d7f44083@proxmox.com> Date: Wed, 6 Sep 2023 11:18:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-GB To: Proxmox VE development discussion , Philipp Hufnagl References: <20230905135122.2145462-1-p.hufnagl@proxmox.com> From: Thomas Lamprecht Autocrypt: addr=t.lamprecht@proxmox.com; keydata= xsFNBFsLjcYBEACsaQP6uTtw/xHTUCKF4VD4/Wfg7gGn47+OfCKJQAD+Oyb3HSBkjclopC5J uXsB1vVOfqVYE6PO8FlD2L5nxgT3SWkc6Ka634G/yGDU3ZC3C/7NcDVKhSBI5E0ww4Qj8s9w OQRloemb5LOBkJNEUshkWRTHHOmk6QqFB/qBPW2COpAx6oyxVUvBCgm/1S0dAZ9gfkvpqFSD 90B5j3bL6i9FIv3YGUCgz6Ue3f7u+HsEAew6TMtlt90XV3vT4M2IOuECG/pXwTy7NtmHaBQ7 UJBcwSOpDEweNob50+9B4KbnVn1ydx+K6UnEcGDvUWBkREccvuExvupYYYQ5dIhRFf3fkS4+ wMlyAFh8PQUgauod+vqs45FJaSgTqIALSBsEHKEs6IoTXtnnpbhu3p6XBin4hunwoBFiyYt6 YHLAM1yLfCyX510DFzX/Ze2hLqatqzY5Wa7NIXqYYelz7tXiuCLHP84+sV6JtEkeSUCuOiUY virj6nT/nJK8m0BzdR6FgGtNxp7RVXFRz/+mwijJVLpFsyG1i0Hmv2zTn3h2nyGK/I6yhFNt dX69y5hbo6LAsRjLUvZeHXpTU4TrpN/WiCjJblbj5um5eEr4yhcwhVmG102puTtuCECsDucZ jpKpUqzXlpLbzG/dp9dXFH3MivvfuaHrg3MtjXY1i+/Oxyp5iwARAQABzTNUaG9tYXMgTGFt cHJlY2h0IChBdXRoLTQpIDx0LmxhbXByZWNodEBwcm94bW94LmNvbT7CwY4EEwEIADgWIQQO R4qbEl/pah9K6VrTZCM6gDZWBgUCWwuNxgIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAK CRDTZCM6gDZWBm/jD/4+6JB2s67eaqoP6x9VGaXNGJPCscwzLuxDTCG90G9FYu29VcXtubH/ bPwsyBbNUQpqTm/s4XboU2qpS5ykCuTjqavrcP33tdkYfGcItj2xMipJ1i3TWvpikQVsX42R G64wovLs/dvpTYphRZkg5DwhgTmy3mRkmofFCTa+//MOcNOORltemp984tWjpR3bUJETNWpF sKGZHa3N4kCNxb7A+VMsJZ/1gN3jbQbQG7GkJtnHlWkw9rKCYqBtWrnrHa4UAvSa9M/XCIAB FThFGqZI1ojdVlv5gd6b/nWxfOPrLlSxbUo5FZ1i/ycj7/24nznW1V4ykG9iUld4uYUY86bB UGSjew1KYp9FmvKiwEoB+zxNnuEQfS7/Bj1X9nxizgweiHIyFsRqgogTvLh403QMSGNSoArk tqkorf1U+VhEncIn4H3KksJF0njZKfilrieOO7Vuot1xKr9QnYrZzJ7m7ZxJ/JfKGaRHXkE1 feMmrvZD1AtdUATZkoeQtTOpMu4r6IQRfSdwm/CkppZXfDe50DJxAMDWwfK2rr2bVkNg/yZI tKLBS0YgRTIynkvv0h8d9dIjiicw3RMeYXyqOnSWVva2r+tl+JBaenr8YTQw0zARrhC0mttu cIZGnVEvQuDwib57QLqMjQaC1gazKHvhA15H5MNxUhwm229UmdH3KM7BTQRbC43GARAAyTkR D6KRJ9Xa2fVMh+6f186q0M3ni+5tsaVhUiykxjsPgkuWXWW9MbLpYXkzX6h/RIEKlo2BGA95 QwG5+Ya2Bo3g7FGJHAkXY6loq7DgMp5/TVQ8phsSv3WxPTJLCBq6vNBamp5hda4cfXFUymsy HsJy4dtgkrPQ/bnsdFDCRUuhJHopnAzKHN8APXpKU6xV5e3GE4LwFsDhNHfH/m9+2yO/trcD txSFpyftbK2gaMERHgA8SKkzRhiwRTt9w5idOfpJVkYRsgvuSGZ0pcD4kLCOIFrer5xXudk6 NgJc36XkFRMnwqrL/bB4k6Pi2u5leyqcXSLyBgeHsZJxg6Lcr2LZ35+8RQGPOw9C0ItmRjtY ZpGKPlSxjxA1WHT2YlF9CEt3nx7c4C3thHHtqBra6BGPyW8rvtq4zRqZRLPmZ0kt/kiMPhTM 8wZAlObbATVrUMcZ/uNjRv2vU9O5aTAD9E5r1B0dlqKgxyoImUWB0JgpILADaT3VybDd3C8X s6Jt8MytUP+1cEWt9VKo4vY4Jh5vwrJUDLJvzpN+TsYCZPNVj18+jf9uGRaoK6W++DdMAr5l gQiwsNgf9372dbMI7pt2gnT5/YdG+ZHnIIlXC6OUonA1Ro/Itg90Q7iQySnKKkqqnWVc+qO9 GJbzcGykxD6EQtCSlurt3/5IXTA7t6sAEQEAAcLBdgQYAQgAIBYhBA5HipsSX+lqH0rpWtNk IzqANlYGBQJbC43GAhsMAAoJENNkIzqANlYGD1sP/ikKgHgcspEKqDED9gQrTBvipH85si0j /Jwu/tBtnYjLgKLh2cjv1JkgYYjb3DyZa1pLsIv6rGnPX9bH9IN03nqirC/Q1Y1lnbNTynPk IflgvsJjoTNZjgu1wUdQlBgL/JhUp1sIYID11jZphgzfDgp/E6ve/8xE2HMAnf4zAfJaKgD0 F+fL1DlcdYUditAiYEuN40Ns/abKs8I1MYx7Yglu3RzJfBzV4t86DAR+OvuF9v188WrFwXCS RSf4DmJ8tntyNej+DVGUnmKHupLQJO7uqCKB/1HLlMKc5G3GLoGqJliHjUHUAXNzinlpE2Vj C78pxpwxRNg2ilE3AhPoAXrY5qED5PLE9sLnmQ9AzRcMMJUXjTNEDxEYbF55SdGBHHOAcZtA kEQKub86e+GHA+Z8oXQSGeSGOkqHi7zfgW1UexddTvaRwE6AyZ6FxTApm8wq8NT2cryWPWTF BDSGB3ujWHMM8ERRYJPcBSjTvt0GcEqnd+OSGgxTkGOdufn51oz82zfpVo1t+J/FNz6MRMcg 8nEC+uKvgzH1nujxJ5pRCBOquFZaGn/p71Yr0oVitkttLKblFsqwa+10Lt6HBxm+2+VLp4Ja 0WZNncZciz3V3cuArpan/ZhhyiWYV5FD0pOXPCJIx7WS9PTtxiv0AOS4ScWEUmBxyhFeOpYa DrEx In-Reply-To: <20230905135122.2145462-1-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: improve vm/container migration user experience X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2023 09:19:06 -0000 subject is quite confusing, this isn't for what's commonly understood w.r.t. the "VM/CT migration", i.e., live migration to another host. You at least need to use the word "pool" somewhere.. Am 05/09/2023 um 15:51 schrieb Philipp Hufnagl: > After the implementation of fix #474, it has been suggested that > instead of requiring the user to click a checkbox allowing migration, > it should be allowed automatically and and a warning should be displaye= d >=20 > Further it has been discussed to rename the feature from "transfer" to > "migrate". However and API change would break already implemented usage= Not sure if I'd call that a discussion, I stated: > We normally use "move" or "migrate", not "transfer", or "reassign" (lik= e for > moving a guest disk to another guest) and it has some merits to not exp= and the > commonly used (parameter) naming scheme to much, but oh well it's alrea= dy released > and a naming nit that doesn't matters _that_ much. And overlooked the "renaming to "migrate" or "migrate from other pool" pa= rt in your reply (while at it, still missing the adding the API default). This was not intended to be a final instruction to definitively use "migr= ate" here, but rather open the discussion for a possible better name, or even = keep that if there's consensus that "transfer" or "reassign" is fine. > and so it has been decided to call it (for now) transfer everywhere to > avoid confusion That again conflicts with your subject message and your statement that you will rename it. Besides that, by whom has it been decided where? This again sounds like there was some actual discussion, but I don't see any. If you want to keep transfer for now, ok, but do so consistently (e.g., a= lso in the commit message's subject here then =E2=80=93 but still with "pool"= mentioned, otherwise one cannot possible know what this is actually about..) >=20 > Signed-off-by: Philipp Hufnagl > --- > www/manager6/grid/PoolMembers.js | 29 ++++++++++++++++++++++------- > 1 file changed, 22 insertions(+), 7 deletions(-) >=20 > diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolM= embers.js > index 224daca3..d6fa0278 100644 > --- a/www/manager6/grid/PoolMembers.js > +++ b/www/manager6/grid/PoolMembers.js > @@ -35,6 +35,20 @@ Ext.define('PVE.pool.AddVM', { > ], > }); > =20 > + let transferWarning =3D Ext.create('Ext.form.field.Display', { > + userCls: 'pmx-hint', > + value: gettext('One or more vms or container will be removed from= their old pool'), if you use the word "vms" you'd need to write it as "VMs", but rather: gettext('Virtual guests are removed from current pools'), > + hidden: true, > + }); > + > + let transfer =3D Ext.create('Ext.form.field.Checkbox', { > + name: 'transfer', > + boxLabel: gettext('Allow Transfer'), > + inputValue: 1, > + hidden: true, > + value: 0, > + }); no need for this, just add: extraRequestParams: { transfer: 1, } to the edit window config. > + > var vmGrid =3D Ext.create('widget.grid', { > store: vmStore, > border: true, > @@ -46,9 +60,15 @@ Ext.define('PVE.pool.AddVM', { > listeners: { > selectionchange: function(model, selected, opts) { > var selectedVms =3D []; > + var isTransfer =3D false; > selected.forEach(function(vm) { > selectedVms.push(vm.data.vmid); > + if (vm.data.pool !=3D=3D '') { I'd prefer: if (vm.data.pool?.length) { as !=3D=3D '' seems rather brittle. > + isTransfer =3D true; > + } > }); > + transfer.setValue(isTransfer); > + transferWarning.setHidden(!isTransfer); > vmsField.setValue(selectedVms); > }, > }, > @@ -90,15 +110,10 @@ Ext.define('PVE.pool.AddVM', { > ], > }); > =20 > - let transfer =3D Ext.create('Ext.form.field.Checkbox', { > - name: 'transfer', > - boxLabel: gettext('Allow Transfer'), > - inputValue: 1, > - value: 0, > - }); > + adding extra empty line here > Ext.apply(me, { > subject: gettext('Virtual Machine'), > - items: [vmsField, vmGrid, transfer], > + items: [vmsField, vmGrid, transferWarning, transfer], > }); > =20 > me.callParent();