From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EE37A6A348 for ; Wed, 16 Mar 2022 11:00:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E529025E98 for ; Wed, 16 Mar 2022 11:00:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2EC8825E8E for ; Wed, 16 Mar 2022 11:00:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 01252463EE for ; Wed, 16 Mar 2022 11:00:35 +0100 (CET) Message-ID: <81032125-67bc-d2ec-e2dd-cb7017ec1c11@proxmox.com> Date: Wed, 16 Mar 2022 11:00:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20220309100919.31512-1-f.ebner@proxmox.com> <1647272668.dywyj5zjzo.astroid@nora.none> From: Fabian Ebner In-Reply-To: <1647272668.dywyj5zjzo.astroid@nora.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.122 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] partially-applied: [PATCH-SERIES v12 qemu-server/manager] API for disk import and OVF X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 10:00:36 -0000 Am 14.03.22 um 16:57 schrieb Fabian Grünbichler: > applied qemu-server patches except 11 and 14-16, see comments on > indivudal patches. > Thanks a lot for the review/feedback! > some unrelated but possibly fix-able as followup things I noticed: > - cloning a running VM with an EFI disk fails, the EFI disk is not > mirrorable (so we need another check like for TPM state?) Isn't that just when the target storage allocates a different-sized disk, i.e. https://bugzilla.proxmox.com/show_bug.cgi?id=3227 > - cancelling a running clone doesn't cleanup properly (stops with trying > to aquire lock and leaves the target VM locked & existing) > Will take a look.