From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6A959686FF for ; Thu, 9 Sep 2021 17:54:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 52B71A93B for ; Thu, 9 Sep 2021 17:53:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D82B8A930 for ; Thu, 9 Sep 2021 17:53:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A37EF4465C for ; Thu, 9 Sep 2021 17:53:51 +0200 (CEST) Message-ID: <80c2e6fd-4540-4fd0-d051-573c9e1ff656@proxmox.com> Date: Thu, 9 Sep 2021 17:53:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Thunderbird/92.0 Content-Language: en-US To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20210909124042.2900922-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210909124042.2900922-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.292 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server] fix #3608: unbreak removal of scsi controller X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Sep 2021 15:54:22 -0000 On 09.09.21 14:40, Fabian Gr=C3=BCnbichler wrote: > the assumption that the index of the controller matches that of the las= t > removed drive only holds for virtio-scsi-single controller, which makes= > the old code print a warning when removing the last drive of a > non-virtio-scsi-single controller except when the indices line up by > chance. >=20 > we can simply only call a simplified qemu_iothread_del when removing a > scsi disk of a VM with the virtio-scsi-single controller, and skip the > call for the other controllers which don't support io-threads anyway. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- > alternatively we could keep the old version but conditionally only call= > it for virtioscsi.* and not for scsihw.*, but the now aligned signature= > for adding and removing iothread objects seems like a nice bonus to me > ;) >=20 > PVE/QemuServer.pm | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) >=20 > applied, thanks! Thrown in some white space/indentation fixes I noticed i= n the surrounding code when checking out this patch more closely.