From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 208521FF16F for <inbox@lore.proxmox.com>; Thu, 16 Jan 2025 11:03:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BAC5D1C82B; Thu, 16 Jan 2025 11:03:16 +0100 (CET) Message-ID: <80a47593-91e0-41cc-ad0f-6e9e5e5c5e5f@proxmox.com> Date: Thu, 16 Jan 2025 11:03:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Alexander Zeidler <a.zeidler@proxmox.com> References: <20250110165807.3-1-a.zeidler@proxmox.com> Content-Language: en-US From: Daniel Kral <d.kral@proxmox.com> In-Reply-To: <20250110165807.3-1-a.zeidler@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs v3 1/2] pvesr: update the chapter and bring it into good condition X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 1/10/25 17:58, Alexander Zeidler wrote: > Existing information is preserved in a restructured way and usefully > supplemented. > > * restructure and revise the introduction > * add subchapter "Considerations" > * remove the subchapter "Schedule Format" with its one line of content > and link where appropriate directly to the copy under "25. Appendix D: > Calendar Events". The help button at adding/editing a job links now to > the subchapter "Managing Jobs". > * provide details on job removal and how to enforce it if necessary > * add more helpful CLI examples and improve/fix existing ones > * restructure and revise the subchapter "Error Handling" > > Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com> > --- > v3: > * adapt the introduction and section "Risk of Data Loss" to provide > information about using a shared storage together with storage > replication > * update the CLI example `pvesr update` (*:00 replaces incorrect */00) > * implement most suggestions from Daniel Kral > ** update commit message > ** reword first paragraph of introduction > ** rename subchapter "Recommendations" to "Considerations" > ** write "every 15 minutes" to be consistent with UI (and additionally > mention that examples from the drop-down list can be modified) > ** reword the description of the bandwidth limit > > v2: https://lore.proxmox.com/pve-devel/20241218161948.3-1-a.zeidler@proxmox.com/ > * no changes, only add missing pve-manager patch > > pvecm.adoc | 2 + > pvesr.adoc | 411 +++++++++++++++++++++++++++++++++++++---------------- > 2 files changed, 287 insertions(+), 126 deletions(-) I've read another time through the article and it reads great again - nothing to complain from my side ;). The description for why the anchors were created could've still landed in the commit message, but that's just a tiny nit for me. Otherwise thanks for the great article, consider this: Reviewed-by: Daniel Kral <d.kral@proxmox.com> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel