From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DCF33D5EE for ; Thu, 21 Sep 2023 13:39:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BEE9A1F193 for ; Thu, 21 Sep 2023 13:39:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 21 Sep 2023 13:39:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EB0AA48668 for ; Thu, 21 Sep 2023 13:39:31 +0200 (CEST) Date: Thu, 21 Sep 2023 13:39:31 +0200 From: Christoph Heiss To: Thomas Lamprecht Cc: Proxmox VE development discussion , Aaron Lauterer Message-ID: <7pceqwz6s5zqrkkkaqww4plzhwgzgjsgxwfdjqj7hxwostkds3@hbaxjh7zdrjs> References: <20230905132832.3179097-1-a.lauterer@proxmox.com> <20230905132832.3179097-3-a.lauterer@proxmox.com> <539fc219-86cc-43e7-b2c6-470c068169fb@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <539fc219-86cc-43e7-b2c6-470c068169fb@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC installer 2/6] add proxmox-auto-installer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2023 11:39:32 -0000 On Thu, Sep 21, 2023 at 01:30:33PM +0200, Thomas Lamprecht wrote: > > Am 21/09/2023 um 13:16 schrieb Christoph Heiss: [..] > > Sending simple JSON-formatted logs to an HTTP endpoint or even using > > the rsyslog protocol come to mind and would be a good solution for > > this, I think. > > Or, if the answer file is read from an (USB drive) partition, write > > the log there? > > I think this should be added to the config as option and default to > "stop-and-wait-for-human-intervention", i.e., show error in a prompt > and wait. Yeah, seems even better to make it a conscious choice for administrators with a sensible default. > > We can then add other reporting mechanisms in the future, possibly > dependent on where the config is pulled from. > [..] > > Further, a way to run commands in the finished installation chroot could > > be pretty useful too, e.g. to create some files in /etc comes to mind. > > I would like to avoid having such things from the start, let's keep > it simple for now and collect feedback when this is then released. > As then, we can decide which mechanism make sense as native feature > and if we really want such a general hook that can allow users to > break lots off stuff and assumptions and still say "well I used the > official installer", i.e., cause support overhead. No objections here either - I was just spilling out some of my thoughts while messing around with it for testing. Esp. the latter is quite a good point, how to handle that "correctly" without causing us pain.