From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 62AFE9D092 for ; Wed, 25 Oct 2023 10:28:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 446CE1194B for ; Wed, 25 Oct 2023 10:28:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 25 Oct 2023 10:28:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 89B2A45D19; Wed, 25 Oct 2023 10:28:03 +0200 (CEST) Date: Wed, 25 Oct 2023 10:28:02 +0200 From: Christoph Heiss To: Gilberto Ferreira Cc: Proxmox VE development discussion , Thomas Lamprecht Message-ID: <7l5h7ecjzznfpagtvnk7xcp7s2cu7njnnext2dp4zcwgyxbk3p@r5nlqvepijry> References: <20231024115530.1101733-1-c.heiss@proxmox.com> <20231024115530.1101733-2-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add new ZFS `arc_max` setup option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2023 08:28:04 -0000 On Tue, Oct 24, 2023 at 08:59:36AM -0300, Gilberto Ferreira via pve-devel wrote: > Date: Tue, 24 Oct 2023 08:59:36 -0300 > From: Gilberto Ferreira > To: Proxmox VE development discussion > Subject: Re: [pve-devel] [PATCH installer v2 1/6] fix #4829: install: add > new ZFS `arc_max` setup option > > > Hi there. > Now, that's a good option in the installer. > I wonder if this option will be available post-intall, like some box in the > ZFS manager from WEB GUI! > That's would be nice. > Currently, this isn't planned, although - since that setting is exposed after all in the installer in the future - it would be kind of sensible to add it to the GUI as well, I guess. But as a separate series from this one, of course. CC @Thomas - what do you think? If you think this is something worth doing, I'd create a proper bugzilla ticket with some more details. My thinking here (roughly) would be: * Move the {default,clamp}_zfs_arc_max() stuff to pve-common * As for the API, probably shove it under `/nodes/{node}/config`? It's a per-node configuration after all, it seems to fit there best without introducing another endpoint just for this * GUI-wise; if we do the above, it probably should also go under node -> system -> options .. Otherwise, add a small, separate panel for options to node -> disks -> zfs maybe?