From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EA5791FF171 for <inbox@lore.proxmox.com>; Fri, 29 Nov 2024 15:33:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 626121B92F; Fri, 29 Nov 2024 15:33:58 +0100 (CET) Message-ID: <7fe38dd6-447c-4750-aee1-1b7bc3c6beba@proxmox.com> Date: Fri, 29 Nov 2024 15:33:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com References: <20240531100753.40964-1-f.ebner@proxmox.com> <20240531100753.40964-2-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20240531100753.40964-2-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs] backup: warn that tar does not honor exclusion pattern with a trailing slash X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 31.05.24 um 12:07 schrieb Fiona Ebner: > As reported in the community forum [0], for tar, an exclusion pattern > with a trailing slash will not match a folder with that name. For > rsync and proxmox-backup-client however, such a pattern will exclude > a directory with that name, but not a file. > > rsync is used for 'suspend' mode backup and tar is used for all > non-PBS backups to create the archive. So currently, in the presence > of an exclusion pattern with a trailing slash, there is inconsistency > between different backup modes (because for 'suspend' mode, rsync will > already do the exclusion too) as well as between PBS and non-PBS > backups. > > There doesn't seem to be a straight-forward way to align the behavior > for tar with command-line options exactly. The trailing slash can't be > removed from the pattern, because that would also match files. > Matching with >> some/pattern/* >> some/pattern/.* > rather than >> some/pattern/ > gets pretty close, which was suggested by Dominik. Just the empty > directory is still included. > > In any case, modifying current behavior would be a breaking change, so > actually aligning the exclusion (more closely) is better done in the > next major release. > > Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> Ping (it seems the related docs patch here was not yet applied yet, while the warning in pve-container was). _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel