From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3BCAA985FF for ; Mon, 24 Apr 2023 12:11:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1408F2FF6D for ; Mon, 24 Apr 2023 12:10:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Apr 2023 12:10:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 40372451B7 for ; Mon, 24 Apr 2023 12:10:33 +0200 (CEST) Message-ID: <7f382106-6011-c33a-1201-0bf1f069aca9@proxmox.com> Date: Mon, 24 Apr 2023 12:10:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Fiona Ebner References: <20230417070914.13808-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230417070914.13808-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied-series: [PATCH manager 1/2] ui: clone: validate name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2023 10:11:05 -0000 On 17/04/2023 09:09, Fiona Ebner wrote: > As reported in the community forum[0], as opposed to VM/LXC creation, > there is no validation for the name in the clone dialog. Use the same > validation as the guest creation wizards do to catch errors early, > before sending the API request. > > [0]: https://forum.proxmox.com/threads/125883/#post-549304 > > Signed-off-by: Fiona Ebner > --- > www/manager6/window/Clone.js | 1 + > 1 file changed, 1 insertion(+) > > applied both patches, thanks!