From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EABF6C381 for ; Mon, 28 Nov 2022 15:37:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 859EE35562 for ; Mon, 28 Nov 2022 15:36:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 28 Nov 2022 15:36:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A972644DA8; Mon, 28 Nov 2022 15:36:53 +0100 (CET) Message-ID: <7e977e99-f586-5b9a-4121-aee36cd59a4d@proxmox.com> Date: Mon, 28 Nov 2022 15:36:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox Backup Server development discussion , pmg-devel@lists.proxmox.com, pve-devel@lists.proxmox.com References: <20221007111859.205737-1-m.heiserer@proxmox.com> <20221007111859.205737-3-m.heiserer@proxmox.com> <59f5469a-0502-c715-4be3-6157f3f5f2fa@proxmox.com> From: Matthias Heiserer In-Reply-To: <59f5469a-0502-c715-4be3-6157f3f5f2fa@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.257 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [pbs-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2022 14:37:25 -0000 On 28.11.2022 08:32, Thomas Lamprecht wrote: > Am 07/10/2022 um 13:18 schrieb Matthias Heiserer: >> Signed-off-by: Matthias Heiserer >> --- >> >> Changes from v1: >> remove both action column styles >> >> www/css/ext6-pbs.css | 14 -------------- >> 1 file changed, 14 deletions(-) >> >> diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css >> index 3c8bed55..7fc60eee 100644 >> --- a/www/css/ext6-pbs.css >> +++ b/www/css/ext6-pbs.css >> @@ -127,20 +127,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled { >> color: #cfcfcf; >> } >> >> -/* fix action column icons */ >> -.x-action-col-icon { >> - font-size: 13px; >> - height: 13px; >> -} >> - >> -.x-grid-cell-inner-action-col { >> - padding: 6px 10px 5px; >> -} > > ^- above rule gets lost and bloats up vertical padding quite a bit in the progress, > there's no commit message so a bit hard to tell, but just from the subject I'd think > that this is meant to be done, or? I figured we want to have the same style on all products. Should I send a v2 and keep this line in PBS, or add it to the widget toolkit? > >> - >> -.x-action-col-icon:before { >> - color: #555; >> -} >> - >> .x-treelist-item-icon { >> color: #000; >> } >