From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3209197D2C for ; Wed, 6 Mar 2024 12:37:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10E07163A9 for ; Wed, 6 Mar 2024 12:37:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 12:37:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0ECA9487DA for ; Wed, 6 Mar 2024 12:37:41 +0100 (CET) Message-ID: <7e5be1a9-71e6-41fe-870b-7fbae120cb6c@proxmox.com> Date: Wed, 6 Mar 2024 12:37:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Hannes Duerr References: <20240306104703.115366-1-h.duerr@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20240306104703.115366-1-h.duerr@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server 1/1] fix 1734: clone VM: if deactivation fails demote error to warning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 11:37:45 -0000 Thanks for tackling this! Can confirm this patch demotes the error to a warning and lets the qmclone task succeed (with a warning). GUI shows "Warnings: 1" and task log contains: can't deactivate LV '/dev/foobar/vm-100-disk-0': Logical volume foobar/vm-100-disk-0 in use. WARN: volume deactivation failed: foobar:vm-100-disk-0 at /usr/share/perl5/PVE/Storage.pm line 1246. Small nits in-line: On 06/03/2024 11:47, Hannes Duerr wrote: > When a template with disks on LVM is cloned to another node, the storage > is first activated, then cloned and deactivated again after cloning. s/storage is/volumes are/g > > However, if clones of this template are now created in parellel to other typo: parallel > nodes, it can happen that one of the tasks can no longer deactivate the > logical volume because it is still in use. The reason for this is that > we use a shared lock. > Since the failed deactivation does not necessarily have consequences, we > downgrade the error to a warning, which means that the clone tasks will > continue to be completed successfully. > > Signed-off-by: Hannes Duerr > --- > PVE/API2/Qemu.pm | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 69c5896..f1e88b8 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -48,6 +48,7 @@ use PVE::DataCenterConfig; > use PVE::SSHInfo; > use PVE::Replication; > use PVE::StorageTunnel; > +use PVE::RESTEnvironment qw(log_warn); > > BEGIN { > if (!$ENV{PVE_GENERATING_DOCS}) { > @@ -3820,7 +3821,13 @@ __PACKAGE__->register_method({ > > if ($target) { > # always deactivate volumes - avoid lvm LVs to be active on several nodes > - PVE::Storage::deactivate_volumes($storecfg, $vollist, $snapname) if !$running; > + eval { > + PVE::Storage::deactivate_volumes($storecfg, $vollist, $snapname) if !$running; > + }; > + my $err = $@; > + if ($err) { > + log_warn("$err\n"); > + } I think the extra \n adds an unnecessary newline here, which looks a bit weird in the task log (though I'm not sure why the `chomp` in `log_warn` doesn't remove the newline). While at it, I think the four lines can be shortened to > log_warn($@) if $@; Though that might be too terse -- someone with more Perl experience than me should judge that :) > PVE::Storage::deactivate_volumes($storecfg, $newvollist); > > my $newconffile = PVE::QemuConfig->config_file($newid, $target);