From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E78D78A301 for ; Wed, 19 Oct 2022 12:16:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BD60133238 for ; Wed, 19 Oct 2022 12:15:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Oct 2022 12:15:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F2E65449EC for ; Wed, 19 Oct 2022 12:15:54 +0200 (CEST) Message-ID: <7e297066-5bb5-fb29-3ddf-a3a12733cc45@proxmox.com> Date: Wed, 19 Oct 2022 12:15:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 To: pve-devel@lists.proxmox.com References: <20221019100036.364733-1-a.lauterer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20221019100036.364733-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: dc: subscription: fix subscription check X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2022 10:16:26 -0000 On 10/19/22 12:00, Aaron Lauterer wrote: > With the change to the rust backend for the subscription check, the > return value changed as well. > > Signed-off-by: Aaron Lauterer > --- > This is the simple fix. We could also change it to lower case first, if > we expect that this might change again. > > I don't think that PMG is affected by this, am not 100% sure. > > www/manager6/dc/Support.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/dc/Support.js b/www/manager6/dc/Support.js > index 1b51e5ba..b8e9b2ff 100644 > --- a/www/manager6/dc/Support.js > +++ b/www/manager6/dc/Support.js > @@ -61,7 +61,7 @@ Ext.define('PVE.dc.Support', { > }, > success: function(response, opts) { > let data = response.result.data; > - if (data.status === 'Active') { > + if (data.status === 'active') { > if (data.level === 'c') { > me.updateCommunity(data); > } else { i'd rather fix it like we did the other places: data.status.toLowerCase() === 'active' to check both variants