From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0D6D970EB9; Mon, 25 Jul 2022 10:05:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EF0A327777; Mon, 25 Jul 2022 10:04:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Mon, 25 Jul 2022 10:04:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D665B4046F; Mon, 25 Jul 2022 10:04:27 +0200 (CEST) Message-ID: <7e032d2a-389f-6df5-8ec9-0eca4d3e163e@proxmox.com> Date: Mon, 25 Jul 2022 10:04:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Wolfgang Bumiller Cc: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com References: <20220720105948.291740-1-f.ebner@proxmox.com> <20220720105948.291740-6-f.ebner@proxmox.com> <20220722105328.ryil3wqnumrrg7hd@wobu-vie.proxmox.com> From: Fiona Ebner In-Reply-To: <20220722105328.ryil3wqnumrrg7hd@wobu-vie.proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC/PATCH pve-common 5/5] pbs client: backup fs tree: drop namespace parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2022 08:05:09 -0000 Am 22.07.22 um 12:53 schrieb Wolfgang Bumiller: > On Wed, Jul 20, 2022 at 12:59:45PM +0200, Fabian Ebner wrote: >> Instead, use the one from the initial configuration. The only current >> caller is in PMG and the namespace parameter set there agrees with >> the one from the initial configuration, so this is not actually a >> breaking change. > > Still technically a breaking change ;-) > Yeah, should've written "not a breaking change in practice" instead. >> >> Signed-off-by: Fabian Ebner >> --- >> src/PVE/PBSClient.pm | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm >> index 34d3f67..d7dd6e1 100644 >> --- a/src/PVE/PBSClient.pm >> +++ b/src/PVE/PBSClient.pm >> @@ -274,7 +274,7 @@ sub get_snapshots { >> # create a new PXAR backup of a FS directory tree - doesn't cross FS boundary >> # by default. >> sub backup_fs_tree { >> - my ($self, $root, $id, $pxarname, $cmd_opts, $namespace) = @_; >> + my ($self, $root, $id, $pxarname, $cmd_opts) = @_; > > And in theory the namespace *could* be overwritable via `$cmd_opts` (if > we used `//=` below. > > But even better yet, since it's not used anywhere, maybe we should just > drop `$cmd_opts` entirely? > Fine by me. If we need more flexibility in the future, we can still add it back, maybe only exposing specific options rather than everything run_raw_client_cmd can take. >> >> die "backup-id not provided\n" if !defined($id); >> die "backup root dir not provided\n" if !defined($root); >> @@ -288,7 +288,7 @@ sub backup_fs_tree { >> >> $cmd_opts //= {}; >> >> - $cmd_opts->{namespace} = $namespace if defined($namespace); >> + $cmd_opts->{namespace} = $self->{scfg}->{namespace} if defined($self->{scfg}->{namespace}); >> >> return run_raw_client_cmd($self, 'backup', $param, %$cmd_opts); >> }; >> -- >> 2.30.2