From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 5DE1C1FF187
for <inbox@lore.proxmox.com>; Mon, 30 Jun 2025 17:09:11 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 38D951E749;
Mon, 30 Jun 2025 17:09:48 +0200 (CEST)
Message-ID: <7da82093-3cf8-4f15-bce8-493f8afd6d2c@proxmox.com>
Date: Mon, 30 Jun 2025 17:09:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
References: <20250620143148.218469-1-d.kral@proxmox.com>
<20250620143148.218469-41-d.kral@proxmox.com>
From: =?UTF-8?Q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>
Content-Language: en-US
In-Reply-To: <20250620143148.218469-41-d.kral@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.014 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager v2 5/5] ui: ha: add ha rules
components and menu entry
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 6/20/25 16:31, Daniel Kral wrote:
> diff --git a/www/manager6/ha/Rules.js b/www/manager6/ha/Rules.js
> new file mode 100644
> index 00000000..d69aa3b2
> --- /dev/null
> +++ b/www/manager6/ha/Rules.js
> @@ -0,0 +1,228 @@
> +Ext.define('PVE.ha.RulesBaseView', {
> + extend: 'Ext.grid.GridPanel',
> +
> + initComponent: function () {
> + let me = this;
> +
> + if (!me.ruleType) {
> + throw 'no rule type given';
> + }
> +
> + let store = new Ext.data.Store({
> + model: 'pve-ha-rules',
> + autoLoad: true,
> + filters: [
> + {
> + property: 'type',
> + value: me.ruleType,
> + },
> + ],
> + });
> +
> + let reloadStore = () => store.load();
> +
> + let sm = Ext.create('Ext.selection.RowModel', {});
> +
> + let createRuleEditWindow = (ruleId) => {
> + if (!me.inputPanel) {
> + throw `no editor registered for ha rule type: ${me.ruleType}`;
> + }
> +
> + Ext.create('PVE.ha.RuleEdit', {
> + panelType: `PVE.ha.rules.${me.inputPanel}`,
> + panelName: me.ruleTitle,
> + ruleType: me.ruleType,
> + ruleId: ruleId,
> + autoShow: true,
> + listeners: {
> + destroy: reloadStore,
> + },
> + });
> + };
> +
> + let runEditor = () => {
> + let rec = sm.getSelection()[0];
> + if (!rec) {
> + return;
> + }
> + let { rule } = rec.data;
> + createRuleEditWindow(rule);
> + };
> +
> + let editButton = Ext.create('Proxmox.button.Button', {
> + text: gettext('Edit'),
> + disabled: true,
> + selModel: sm,
> + handler: runEditor,
> + });
> +
> + let removeButton = Ext.create('Proxmox.button.StdRemoveButton', {
> + selModel: sm,
> + baseurl: '/cluster/ha/rules/',
> + callback: reloadStore,
> + });
> +
> + Ext.apply(me, {
> + store: store,
> + selModel: sm,
> + viewConfig: {
> + trackOver: false,
> + },
> + emptyText: Ext.String.format(gettext('No {0} rules configured.'), me.ruleTitle),
> + tbar: [
> + {
> + text: gettext('Add'),
> + handler: () => createRuleEditWindow(),
> + },
> + editButton,
> + removeButton,
> + ],
> + listeners: {
> + activate: reloadStore,
> + itemdblclick: runEditor,
> + },
> + });
> +
> + me.columns.unshift(
> + {
> + header: gettext('State'),
> + xtype: 'actioncolumn',
> + width: 25,
This is very narrow. Prior to resizing the column, I only see "S". A
width of 65 works quite nicely.
> + align: 'center',
> + dataIndex: 'state',
> + items: [
> + {
> + isActionDisabled: (table, rowIndex, colIndex, item, { data }) =>
> + data.state !== 'contradictory',
> + handler: (table, rowIndex, colIndex, item, event, { data }) => {
> + Ext.create('PVE.ha.RuleErrorsModal', {
> + autoShow: true,
> + errors: data.errors ?? {},
> + });
> + },
> + getTip: (value) => {
> + switch (value) {
> + case 'contradictory':
> + return gettext('Errors');
> + case 'disabled':
> + return gettext('Disabled');
> + default:
> + return gettext('Enabled');
> + }
> + },
> + getClass: (value) => {
> + let iconName = 'check';
> +
> + if (value === 'contradictory') {
> + iconName = 'exclamation-triangle';
> + } else if (value === 'disabled') {
> + iconName = 'minus';
> + }
> +
> + return `fa fa-${iconName}`;
> + },
> + },
> + ],
> + },
> + {
> + header: gettext('Rule'),
> + width: 200,
> + dataIndex: 'rule',
> + },
> + );
> +
> + me.columns.push({
> + header: gettext('Comment'),
> + flex: 1,
> + renderer: Ext.String.htmlEncode,
> + dataIndex: 'comment',
> + });
> +
> + me.callParent();
> + },
> +});
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel