From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 58F95623FB
 for <pve-devel@lists.proxmox.com>; Thu, 20 Aug 2020 17:36:54 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 4C7552E8DB
 for <pve-devel@lists.proxmox.com>; Thu, 20 Aug 2020 17:36:54 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 34CBE2E8CF
 for <pve-devel@lists.proxmox.com>; Thu, 20 Aug 2020 17:36:53 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0083743398
 for <pve-devel@lists.proxmox.com>; Thu, 20 Aug 2020 17:36:53 +0200 (CEST)
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 =?UTF-8?Q?Dominic_J=c3=a4ger?= <d.jaeger@proxmox.com>
References: <20200730101829.52823-1-d.jaeger@proxmox.com>
 <20200730101829.52823-2-d.jaeger@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <7d766efe-9cf4-fe60-a522-c223600cdd6d@proxmox.com>
Date: Thu, 20 Aug 2020 17:36:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101
 Thunderbird/80.0
MIME-Version: 1.0
In-Reply-To: <20200730101829.52823-2-d.jaeger@proxmox.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.603 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.361 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH widget-toolkit v2 1/3] EditWindow: Change
 url to 'importdisk' for import
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2020 15:36:54 -0000

On 30.07.20 12:18, Dominic J=C3=A4ger wrote:
> Signed-off-by: Dominic J=C3=A4ger <d.jaeger@proxmox.com>
> ---
> v1->v2: unchanged
>=20
>  src/window/Edit.js | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/src/window/Edit.js b/src/window/Edit.js
> index d7972b6..2dfab19 100644
> --- a/src/window/Edit.js
> +++ b/src/window/Edit.js
> @@ -134,6 +134,10 @@ Ext.define('Proxmox.window.Edit', {
>  	    values =3D undefined;
>  	}
> =20
> +	if (me.isImport) {
> +	    url =3D url.replace('config', 'importdisk');
> +	}
> +

I'd rather avoid doing this here, i.e., the common shared code should not=

do such transforming things specific for a single use case downstream..
That adds coupling, which should be avoided if possible.

Why can the import window instance not handle this?

sorry to catch this only now..