From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AF6EDC0B9 for ; Fri, 8 Apr 2022 13:40:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A422E4AE for ; Fri, 8 Apr 2022 13:39:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1E6E4E498 for ; Fri, 8 Apr 2022 13:39:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E1B3845A56 for ; Fri, 8 Apr 2022 13:39:56 +0200 (CEST) Message-ID: <7d20889e-8309-0ae2-55c3-36b27f9a3a34@proxmox.com> Date: Fri, 8 Apr 2022 13:39:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20220408074530.1212056-1-d.csapak@proxmox.com> <20220408074530.1212056-10-d.csapak@proxmox.com> From: Matthias Heiserer In-Reply-To: <20220408074530.1212056-10-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.423 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.873 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager v5 05/11] ui: add form/TagColorGrid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 11:40:27 -0000 On 08.04.2022 09:45, Dominik Csapak wrote: 8< > + > + setValue: function(value) { > + let me = this; > + me.setColor(value); > + if (value && value.length === 6) { > + me.picker.value = value[0] !== '#' ? `#${value}` : value; > + } > + }, > + > + setColor: function(value) { > + let me = this; > + let oldValue = me.realvalue; > + me.realvalue = value; > + let color = value.length === 6 ? `#${value}` : undefined; > + me.down('#picker').setStyle('background-color', color);Not a big fan of this initially being white. Makes it somewhat hard to discover. 8< > + > +Ext.define('PVE.form.TagColorGrid', { > + extend: 'Ext.grid.Panel', > + alias: 'widget.pveTagColorGrid', > + > + mixins: [ > + 'Ext.form.field.Field', > + ], > + I don't like how the selection in the grid works. I.e. one has to click the sliver of whitespace between the columns to select a row, while writing doesn't change the selected column. 8<--- > + }, > + ], > + > + columns: [ > + { > + header: 'Tag', > + dataIndex: 'tag', > + xtype: 'widgetcolumn', > + onWidgetAttach: function(col, widget, rec) { > + widget.getStore().setData(PVE.Utils.tagList.map(v => ({ tag: v }))); > + }, > + widget: { > + xtype: 'combobox', > + isFormField: false, > + maskRe: /[a-zA-Z0-9_.-]/, As it gets used several times in different locations (form/Tag), you could consider storing it in a fixed place. 8<---