From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A8B9C1FF15F for ; Mon, 7 Oct 2024 11:48:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BE0913AF80; Mon, 7 Oct 2024 11:49:06 +0200 (CEST) Message-ID: <7cb448b4-a68a-41ea-b874-5bc1bff97140@proxmox.com> Date: Mon, 7 Oct 2024 11:49:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20241007092218.723938-1-c.heiss@proxmox.com> <20241007092218.723938-4-c.heiss@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20241007092218.723938-4-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.633 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 3/3] auto-installer: raise minimum root password length to 8 characters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 10/7/24 11:22, Christoph Heiss wrote: > .. in accordance with current NIST recommendations [0]. > > It's 2024; so reasonable to expect an 8-character-password at the > minimum. > > [0] https://pages.nist.gov/800-63-4/sp800-63b.html#passwordver > > Signed-off-by: Christoph Heiss > --- > proxmox-auto-installer/src/utils.rs | 5 +++++ > .../tests/resources/parse_answer/disk_match.json | 2 +- > .../tests/resources/parse_answer/disk_match.toml | 2 +- > .../tests/resources/parse_answer/disk_match_all.json | 2 +- > .../tests/resources/parse_answer/disk_match_all.toml | 2 +- > .../tests/resources/parse_answer/disk_match_any.json | 2 +- > .../tests/resources/parse_answer/disk_match_any.toml | 2 +- > .../tests/resources/parse_answer/minimal.json | 2 +- > .../tests/resources/parse_answer/minimal.toml | 2 +- > .../tests/resources/parse_answer/nic_matching.json | 2 +- > .../tests/resources/parse_answer/nic_matching.toml | 2 +- > .../tests/resources/parse_answer/specific_nic.json | 2 +- > .../tests/resources/parse_answer/specific_nic.toml | 2 +- > proxmox-auto-installer/tests/resources/parse_answer/zfs.json | 2 +- > proxmox-auto-installer/tests/resources/parse_answer/zfs.toml | 2 +- > 15 files changed, 19 insertions(+), 14 deletions(-) > > diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer/src/utils.rs > index 45ad222..e0dd2ae 100644 > --- a/proxmox-auto-installer/src/utils.rs > +++ b/proxmox-auto-installer/src/utils.rs > @@ -13,6 +13,7 @@ use proxmox_installer_common::{ > setup::{ > InstallConfig, InstallRootPassword, InstallZfsOption, LocaleInfo, RuntimeInfo, SetupInfo, > }, > + ROOT_PASSWORD_MIN_LENGTH, > }; > use serde::{Deserialize, Serialize}; > > @@ -309,6 +310,10 @@ fn verify_root_password_settings(answer: &Answer) -> Result<()> { > } else if answer.global.root_password.is_none() && answer.global.root_password_hashed.is_none() > { > bail!("One of `global.root_password` or `global.root_password_hashed` must be set"); > + } else if answer.global.root_password.is_some() > + && answer.global.root_password.as_ref().map(|s| s.len()) < Some(ROOT_PASSWORD_MIN_LENGTH) > + { > + bail!("`global.root_password` must be at least {ROOT_PASSWORD_MIN_LENGTH} characters long"); > } else { > Ok(()) > } maybe match is better at this point? Something like match (answer.global.root_password, answer.global.root_password_hashed) { [..] (Some(password), _) if password.len() < ROOT_PASSWORD_MIN_LENGTH, [..] } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel