From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3C7AA1FF15E for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 14:29:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8829A1BBAB; Tue, 8 Apr 2025 14:29:12 +0200 (CEST) Message-ID: <7cafdc9c-ad63-4d67-9b2d-994087e5c12d@proxmox.com> Date: Tue, 8 Apr 2025 14:29:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Aaron Lauterer <a.lauterer@proxmox.com> To: pve-devel@lists.proxmox.com References: <20250408103715.1081055-1-a.lauterer@proxmox.com> In-Reply-To: <20250408103715.1081055-1-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server, manager v6 0/4] fix #1926 autodetect xtermjs or novnc for VM console X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> sent a v7 https://lore.proxmox.com/pve-devel/20250408122710.1164112-2-a.lauterer@proxmox.com/T/#m54aae8f7595a1478748c2b61180c46d0cf52e38b On 2025-04-08 12:37, Aaron Lauterer wrote: > We add a new property in the VM status/current API result that includes > the display configurtion of the VM. This way we can check in the > frontend what to do with it. > > I chose a nested return value, as that makes it easier to add/move > additional display properties into it. > > Patch 1/4 makes two functions in QemuServer.pm public. > > > Patch 2/4 adds the new display property. If not explicitly set in the VM > config, it will return the default 'std' value. > > Patch 3/4 implements the changes in the UI. The final result isn't > really a lot simpler on the UI side than in V4 where we had the extra > API call to the VM's config directly. Because we still need to wait for > the API call to finish when initially navigating to the VM. But we have > one fewer call. > > Patch 4/4 then introduces some changes to make loading of the console > faster if we just navigate in the submenu of a VM itself where we > already have the current status of a VM already cached. > > Changes from v5: implement suggestions: > > * use get_vga_properties for default VGA > * UI: use helper to determine if serial display > > qemu-server: Aaron Lauterer (2): > QemuServer: make get_vga_properties and extract_version public > api: status/current: add display property > > PVE/API2/Qemu.pm | 21 +++++++++++++++++++++ > PVE/QemuServer.pm | 4 ++-- > 2 files changed, 23 insertions(+), 2 deletions(-) > > > manager: Aaron Lauterer (2): > fix #1926 ui: vm console: autodetect novnc or xtermjs > ui: console: check on activate if display info for VMs is present > > www/manager6/Utils.js | 4 +++ > www/manager6/VNCConsole.js | 60 ++++++++++++++++++++++++++----------- > www/manager6/qemu/Config.js | 7 ++++- > 3 files changed, 53 insertions(+), 18 deletions(-) > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel