From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 191E169C0E for ; Fri, 25 Mar 2022 09:37:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CB2F3375A5 for ; Fri, 25 Mar 2022 09:37:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 63A0B3759A for ; Fri, 25 Mar 2022 09:37:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3BCCE46F47 for ; Fri, 25 Mar 2022 09:37:08 +0100 (CET) Message-ID: <7c49c1a0-b1ea-0595-6d97-bdb53571ecc0@proxmox.com> Date: Fri, 25 Mar 2022 09:37:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Matthias Heiserer References: <20220324113331.681971-1-m.heiserer@proxmox.com> <20220324113331.681971-2-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220324113331.681971-2-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit 2/2] use the width-helper from utils X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 08:37:39 -0000 please add a prefixing tag to the comment subject: apt repos: use new button max-width helper from utils On 24.03.22 12:33, Matthias Heiserer wrote: > Signed-off-by: Matthias Heiserer > --- > src/node/APTRepositories.js | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js > index 09ed0be..d63a569 100644 > --- a/src/node/APTRepositories.js > +++ b/src/node/APTRepositories.js > @@ -230,16 +230,7 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', { > }); > }, > listeners: { > - render: function(btn) { > - // HACK: calculate the max button width on first render to avoid toolbar glitches > - let defSize = btn.getSize().width; > - > - btn.setText(btn.altText); > - let altSize = btn.getSize().width; > - > - btn.setText(btn.defaultText); > - btn.setSize({ width: altSize > defSize ? altSize : defSize }); > - }, > + render: Proxmox.Utils.calculateWidth, > }, > }, > ],