From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F0C6C74B1A for ; Tue, 22 Jun 2021 11:52:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E2A2225157 for ; Tue, 22 Jun 2021 11:52:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7680B25149 for ; Tue, 22 Jun 2021 11:52:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4038B42EC2 for ; Tue, 22 Jun 2021 11:52:39 +0200 (CEST) Message-ID: <7c398ca5-0933-ac25-53cf-ad86c8586056@proxmox.com> Date: Tue, 22 Jun 2021 11:52:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20210622080726.2361527-1-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210622080726.2361527-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.701 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] ui: dc: backup: fix job detail search X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 09:52:40 -0000 On 22.06.21 10:07, Aaron Lauterer wrote: > 'for...in array' returns the id in the array but not the value, > 'for...of array' returns the values. > > Another issue that I ran into was if the property did not exist. Having something like "another issue fixed with additional changes" is always a good indicator that it could be a separate patch. > > Checking if the property evaluates to false will catch situations where > the property does not exist or is null. All other situations where there > is a value for the name, id or type, should evaluate to true if present > as they are strings or the VMID. > > Signed-off-by: Aaron Lauterer > --- > www/manager6/dc/Backup.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, to both master and stable-6, thanks!