From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 749E861889 for ; Mon, 17 Jan 2022 16:54:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C45F1D354 for ; Mon, 17 Jan 2022 16:54:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 590201D347 for ; Mon, 17 Jan 2022 16:54:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 21D5046BED for ; Mon, 17 Jan 2022 16:54:08 +0100 (CET) Message-ID: <7bf45434-3b45-da5e-6ca4-e187bc87cdca@proxmox.com> Date: Mon, 17 Jan 2022 16:54:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20220117113559.77636-1-f.ebner@proxmox.com> <20220117113559.77636-2-f.ebner@proxmox.com> <1642433537.xfl9w24g55.astroid@nora.none> From: Thomas Lamprecht In-Reply-To: <1642433537.xfl9w24g55.astroid@nora.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 manager 2/2] close #3476: vzdump: add job-init hook X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 15:54:09 -0000 On 17.01.22 16:37, Fabian Gr=C3=BCnbichler wrote: > On January 17, 2022 12:35 pm, Fabian Ebner wrote: >> which allows users to prepare the backup storage for activation (e.g. >> by waking up a remote node). >> >> Suggested-by: Fabian Gr=C3=BCnbichler >> Signed-off-by: Fabian Ebner >=20 > Reviewed-by: Fabian Gr=C3=BCnbichler =20 >=20 > but giving others a chance to object to the new phase before applying ;= ) For the general approach of adding this hook Acked-by: Thomas Lamprecht >> @@ -26,6 +28,14 @@ if ($phase eq 'job-start' || >> print "storeid=3D$storeid;" if defined($storeid); >> print "\n"; >> =20 >> + # example: wake up remote storage node and enable storage >> + if ($phase eq 'job-init') { >> + #system ("") =3D=3D 0 || nit: maybe add a command there so that it's easier to adapt for non-perl = people, whom may not know that above is not some required magic incantation that they = must keep as is. So, e.g.: #system("wakeonlan AA:BB:CC:DD:EE:FF") #sleep(30); but as said, just a nit that caught my eyes, no hard feelings on that wha= tsoever.