From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E380590B18 for ; Mon, 30 Jan 2023 11:53:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C028EDFD3 for ; Mon, 30 Jan 2023 11:53:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 30 Jan 2023 11:53:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D061B4543C for ; Mon, 30 Jan 2023 11:53:44 +0100 (CET) Message-ID: <7beebac9-64b9-2dd9-9ca4-e4b6322bba8a@proxmox.com> Date: Mon, 30 Jan 2023 11:53:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: Proxmox VE development discussion , Thomas Lamprecht , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20230118135448.152425-1-l.nunner@proxmox.com> <1674815875.i6y9hjxurd.astroid@yuna.none> From: Leo Nunner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.125 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix 4481: fetch changelogs for any Proxmox repository X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2023 10:53:46 -0000 On 2023-01-28 14:56, Thomas Lamprecht wrote: > Am 27/01/2023 um 11:41 schrieb Fabian Grünbichler: >> a few improvements possible here: >> - it should be enough that one of the components matches (e.g., I could have >> pvetest and pve-no-subscription configured in a single entry) >> - this should only take enabled repositories into account >> - we should probably also compare the 'Site' member of $pkgfile toe the >> repository URL >> >> since $origin and $component also come from $pkgfile at the call sites, we could >> maybe just pass in $pkgfile? >> >> other than that, this looks okay to me since our components all contain the >> product, so this allows differentiation :) > just to be sure: is ceph with it's `test` and `main` covered too? >From what I can tell: yes, it is. Testing on pacific with the 'test' repository enabled I get $base = "dists/bullseye/test/binary-amd64" $repo->{URIs}[0] = "http://download.proxmox.com/debian/ceph-pacific" which results in the valid URL http://download.proxmox.com/debian/ceph-pacific/dists/bullseye/test/binary-amd64/