From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id BE32E1FF0B3 for ; Wed, 14 Oct 2026 12:16:27 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 724EF2139F; Wed, 14 Oct 2026 12:16:24 +0200 (CEST) Message-ID: <7be4cd99-11ae-42a1-8c26-f8b3351a0f34@proxmox.com> Date: Wed, 14 Oct 2026 12:16:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH kernel-helper] kernel hooks: flag pending reboot after installing a new kernel To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20261013114721.198258-1-j.theisen@proxmox.com> <90364d0b-95b7-4aaf-bb43-ff10dad3eb7e@proxmox.com> <8c5bb528-88f0-49fd-86e9-d3e4d16d16e9@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: <8c5bb528-88f0-49fd-86e9-d3e4d16d16e9@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791972978919 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.130 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ASXG5HX5LQ3EUQQBE2EYXDYGJMK23I7I X-Message-ID-Hash: ASXG5HX5LQ3EUQQBE2EYXDYGJMK23I7I X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/14/26 11:52, Thomas Lamprecht wrote: > Am 14.10.26 um 11:37 schrieb Jonas Theisen: >> >> >> Should i also include these refs in the commit message? > Yes, please, at least in some basic prose form describing how > this is checked/used with [X] reference to the repo/file/docs/... > Ack! >>>> +echo "*** System restart required ***" > /run/reboot-required >>> That's always truncating any existing reboot-required file though? >>> Or doesn't that matter because it will be either not there or contain >>> exactly this string? In any case, needs either fixing or mentioning >>> that its fine in the commit message and maybe even a short >> According to my understanding of this files usage it is just checked >> for existence and printed in the motd. The content seems to be irrelevant. > Ack, then it's at least not that problematic, but potentially still not > nice to blindly override it? Did you check how others - e.g. debian or > ubuntu handles this for kernel updates? As just adding a lot of > complexity with not much gain is not really worth it either, but maybe > others came up with a sensible solution here already. Ubuntu's update-notifier uses the same truncation: data/notify-reboot-required: 26 echo "*** $(eval_gettext "System restart required") ***" > /var/run/reboot-required 27 echo "$DPKG_MAINTSCRIPT_PACKAGE" >> /var/run/reboot-required.pkgs Debian does not have an equivalent natively but the package reboot-notifier works the same way and also truncates the reboot-required file.