From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 03FBB1FF161 for ; Tue, 10 Sep 2024 11:21:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E11A31641; Tue, 10 Sep 2024 11:21:45 +0200 (CEST) Message-ID: <7b5e7a83-ec35-42f0-8684-93433054ffd1@proxmox.com> Date: Tue, 10 Sep 2024 11:21:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Aaron Lauterer References: <20240729115540.191594-1-a.lauterer@proxmox.com> <20240729115540.191594-3-a.lauterer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240729115540.191594-3-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common v4 2/7] fix #3893: network: add vlan id and range parameter definitions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 29.07.24 um 13:55 schrieb Aaron Lauterer: > @@ -595,6 +601,34 @@ sub pve_verify_iface { > return $id; > } > > +# vlan id (vids), single or range > +register_format('pve-vlan-id-or-range', \&pve_verify_vlan_id_or_range); > +sub pve_verify_vlan_id_or_range { > + my ($vlan, $noerr) = @_; > + > + my $check_vid = sub { > + my $tag = shift; > + if ( $tag < 2 || $tag > 4094) { Style nit: extra space after parenthesis > + return undef if $noerr; > + die "invalid VLAN tag '$tag'\n"; > + } > + }; > + > + if ($vlan !~ m/^(\d+)(?:-(\d+))?$/) { > + return undef if $noerr; > + die "invalid VLAN configuration '$vlan'\n"; > + } > + my $start = $1; > + my $end = $2; > + return undef if (!defined $check_vid->($start)); check_vid does not explicitly return anything in the success case, so this check seems very brittle and I guess relies on implicit return? Style nits: parentheses for post-if missing parentheses for defined() perlcritic prefers 'return' over 'return undef' > + if ($end) { > + return undef if (!defined $check_vid->($end)); > + die "VLAN range must go from lower to higher tag '$vlan'" if $start >= $end && !$noerr; What if $noerr is set, but $start >= $end? You want to have a 'return' then, right? > + } > + > + return $vlan; > +} > + > # general addresses by name or IP > register_format('address', \&pve_verify_address); > sub pve_verify_address { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel