From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F1142714D4 for ; Wed, 8 Jun 2022 15:00:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E83E08ACF for ; Wed, 8 Jun 2022 15:00:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 60D718ABB for ; Wed, 8 Jun 2022 15:00:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 62DFD43A79; Wed, 8 Jun 2022 15:00:39 +0200 (CEST) Message-ID: <7b52e845-3bc7-01b3-6882-358739a6d5b9@proxmox.com> Date: Wed, 8 Jun 2022 15:00:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Proxmox VE development discussion , Daniel Bowder References: <20220608115428.250668-1-daniel@bowdernet.com> From: Matthias Heiserer In-Reply-To: <20220608115428.250668-1-daniel@bowdernet.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.710 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.732 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 13:00:42 -0000 On 08.06.2022 13:54, Daniel Bowder wrote: > These five patches add the ability to pin a QEMU VMs processes to a defined set of CPU cores. The changes required spanned multiple repos and have all been included in these five patches. The patches add "cpuset" as an option in the qm configuration file and enable the editing of this parameter via the gui. > Thank you for your patches! Regarding the formatting: Please make sure to follow our Perl and Javascript style guides [0][1] and the Developer Documentation [2]. All your patches use a nonconformant indentation :/ Also, the repository (e.g. qemu-server) should be part of the prefix, next to "PATCH", this makes it easier to parse where they belong. In case you haven't done so yet, we require a CLA (explained in [2]) from you in order to use your code. [0] https://pve.proxmox.com/wiki/Perl_Style_Guide [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide [2] https://pve.proxmox.com/wiki/Developer_Documentation