From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E29DD92E7A for ; Mon, 2 Jan 2023 17:13:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ADFC0322F for ; Mon, 2 Jan 2023 17:12:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 2 Jan 2023 17:12:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C70704506E for ; Mon, 2 Jan 2023 17:12:36 +0100 (CET) Message-ID: <7b068614-68f4-bafe-6239-9ab1890b949f@proxmox.com> Date: Mon, 2 Jan 2023 17:12:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion , Stoiko Ivanov References: <20230102142549.728593-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230102142549.728593-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH zfsonlinux] fix #4440: cherry-pick patch for mountpoint=legacy on / X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2023 16:13:07 -0000 Am 02/01/2023 um 15:25 schrieb Stoiko Ivanov: > As reported having set 'mountpoint=legacy' on the root dataset (for a > default install this would be 'rpool/ROOT/pve-1') for mounting through > e.g. /etc/fstab breaks booting in initramfs > > The cherry-picked patch is already applied to zfs-2.1.8-staging > upstream so will be included in the next zfs point release. > > reproduced the issue on a VM with ZFS on root by: > * booting into a PVE 7.3 iso (to have zfs and an inactive > rpool/ROOT/pve-1) > * `zpool import -ocachefile=none -N -f rpool > * `zfs set mountpoint=legacy rpool/ROOT/pve-1` > * `mount -t zfs rpool/ROOT/pve-1 /mnt > * `echo "rpool/ROOT/pve-1 / zfs defaults 0 0" >> /mnt/etc/fstab` > * `zpool export rpool` > * reboot - the boot breaks with zfs-initramfs 2.1.7-pve1 but works > with this patch applied > > Signed-off-by: Stoiko Ivanov > --- > > The current changes on zfs-2.1.8-staging could all be applied without too > much expected fallout (dracut fixes, aarch64 fixes, tests and testconfig) > If preferred I can send an update of the zfsmodule to the current tip of this > branch instead > no, works fine as is. I prefer pulling targeted fixes, at least if coming from a (unreleased) staging branch/version like here. > ...itramfs-Fix-legacy-mountpoint-rootfs.patch | 58 +++++++++++++++++++ > debian/patches/series | 1 + > 2 files changed, 59 insertions(+) > create mode 100644 debian/patches/0012-initramfs-Fix-legacy-mountpoint-rootfs.patch > > applied, thanks!