From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8358F1FF15F for ; Mon, 18 Nov 2024 10:35:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E4AA7B6AA; Mon, 18 Nov 2024 10:35:42 +0100 (CET) Message-ID: <7acac0b6-a814-4557-b1a1-4050ff6f83c6@proxmox.com> Date: Mon, 18 Nov 2024 10:35:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20241115120937.169342-1-s.hanreich@proxmox.com> <20241115120937.169342-5-s.hanreich@proxmox.com> <067c607a-d1da-4abb-b699-6e2a26ff68cd@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <067c607a-d1da-4abb-b699-6e2a26ff68cd@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.656 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-firewall v4 4/9] add support for loading sdn firewall configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Wolfgang Bumiller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/17/24 15:57, Thomas Lamprecht wrote: > it's a bit odd to assign the full SDN related config to a variable named > $empty_config, but assigning it after the parser will cause a semantic difference > for the case where the firewall config is empty, not sure if that is fine. It has to be beforehand, otherwise if you reference the SDN IPsets in your cluster configuration you will get verification errors since generic_fw_config_parser() will execute the whole validation / verification logic - which fails if IPSets do not exist. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel