From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2598790128 for ; Tue, 2 Apr 2024 11:36:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CEB61A97 for ; Tue, 2 Apr 2024 11:36:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 2 Apr 2024 11:36:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B25C0448E4; Tue, 2 Apr 2024 11:36:51 +0200 (CEST) Message-ID: <7ac34849-f3e3-41ef-a5b2-93f96f378654@proxmox.com> Date: Tue, 2 Apr 2024 11:36:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Fiona Ebner , Proxmox VE development discussion References: <20240318111836.1947580-1-d.csapak@proxmox.com> <20240318111836.1947580-7-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 4/4] api: enable live migration for marked mapped pci devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2024 09:36:53 -0000 On 3/22/24 14:37, Fiona Ebner wrote: > Am 18.03.24 um 12:18 schrieb Dominik Csapak: >> They have to be marked as 'live-migration-capable' in the mapping >> config, and the driver and qemu must support it. >> >> For the gui checks, we now return a list of 'mapped-with-live-migration' >> entries in the migration preflight api call too. >> >> Signed-off-by: Dominik Csapak >> --- >> PVE/API2/Qemu.pm | 5 +++++ >> PVE/QemuMigrate.pm | 12 ++++++++---- >> 2 files changed, 13 insertions(+), 4 deletions(-) >> >> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm >> index 4ecaeb91..8581a529 100644 >> --- a/PVE/API2/Qemu.pm >> +++ b/PVE/API2/Qemu.pm >> @@ -4453,6 +4453,10 @@ __PACKAGE__->register_method({ >> type => 'array', >> description => "List of mapped resources e.g. pci, usb" >> }, >> + 'mapped-with-live-migration' => { >> + type => 'array', >> + description => "List of mapped resources that are marked as capable of live-migration", >> + }, > > Should we merge this with 'mapped-resources' for the next major release > (and add a reminder comment here)? I.e. make that return the objects > with the additional information. yeah i thought about that too, i general i'd really like to revampt the whole api call and it's return values a bit, but that has to wait for a major release since it will be a breaking change (if we don't want to duplicate code and keep the old one around...) i'll add a reminder comment to the api call > >> }, >> }, >> code => sub {