From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E30181FF179 for ; Wed, 29 Oct 2025 12:39:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E10A8F13; Wed, 29 Oct 2025 12:40:01 +0100 (CET) Message-ID: <7ac2bcba-0510-4808-975b-fddbbc13043e@proxmox.com> Date: Wed, 29 Oct 2025 12:39:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Dominik Csapak References: <20250418063400.514006-1-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250418063400.514006-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761737984395 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: properly reset API 401 count X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" I guess this is still relevant? Am 18.04.25 um 8:34 AM schrieb Dominik Csapak: > due to a timing race condition, it can happen that we try to increase > the 401 count before resetting it (which happens after the first > ticket api call). Since `undefined + ` === NaN, our later check for > `> 5` never triggers and we don't show the login mask, but an empty > window. > > To fix this, initialize the variable always with 0. > > Observed when restoring a session after a ticket expired while the > browser was closed. > > Signed-off-by: Dominik Csapak Reviewed-by: Fiona Ebner But it needs a rebase. > --- > www/manager6/Workspace.js | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js > index 922e01df..ca668caa 100644 > --- a/www/manager6/Workspace.js > +++ b/www/manager6/Workspace.js > @@ -13,6 +13,8 @@ Ext.define('PVE.Workspace', { > > loginData: null, // Data from last login call > > + response401count: 0, > + > onLogin: function(loginData) { > // override me > }, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel