From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 66E9391DA8 for ; Sat, 11 Mar 2023 18:26:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44E032BA1F for ; Sat, 11 Mar 2023 18:26:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 11 Mar 2023 18:26:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 76B7442732 for ; Sat, 11 Mar 2023 18:26:35 +0100 (CET) Message-ID: <7aac38ac-81cb-3767-2e50-7152534c9de8@proxmox.com> Date: Sat, 11 Mar 2023 18:26:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <20230307105018.3172827-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230307105018.3172827-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH common] certificate: actually print openssl errors X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2023 17:26:36 -0000 Am 07/03/2023 um 11:50 schrieb Fabian Gr=C3=BCnbichler: > print_errs (which is also called internally by die_now) will only 'warn= ' the > collected error stack if the log level is set to tracing. otherwise, it= will > just return the error message(s) corresponding to the error stack as st= ring. >=20 > while they are not always the most user-friendly ones, they do provide > additional context that might help to find out what is actually causing= a > particular failure. both helpers here actually provide a meaninful user= > friendly context (via $msg) as final line. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- >=20 > Notes: > noticed while testing Max' key check series >=20 > src/PVE/Certificate.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > applied, with merge conflict resolved as I dropped the unused warn helper= and made the error one a local sub instead of a $code ref in-between, tha= nks!