From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9C0E274B60 for ; Wed, 2 Jun 2021 16:43:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F2B5D967 for ; Wed, 2 Jun 2021 16:43:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1C4ADD959 for ; Wed, 2 Jun 2021 16:43:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DF9E2466CB for ; Wed, 2 Jun 2021 16:43:55 +0200 (CEST) Message-ID: <79be0e88-c6a6-ab24-eb48-5e17e74e155e@proxmox.com> Date: Wed, 2 Jun 2021 16:43:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210423101501.27300-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210423101501.27300-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH-SERIES storage/widget-toolkit/manager] Add wipe disk api call and button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 14:43:56 -0000 On 23.04.21 12:14, Fabian Ebner wrote: > widget-toolkit: > > Fabian Ebner (4): > disk list: fix minor usage renderer issue > disk list: factor out renderer for type and usage > disk list: move title bar initialization to initComponent > disk list: add wipe disk button > > src/panel/DiskList.js | 223 ++++++++++++++++++++++++++++++------------ > 1 file changed, 161 insertions(+), 62 deletions(-) > > > manager: > > Fabian Ebner (2): > ui: add task description for wipe disk > ui: disk list: enable wipe disk button > > www/manager6/Utils.js | 1 + > www/manager6/node/Config.js | 1 + > 2 files changed, 2 insertions(+) > applied the remaining patches. Next things to do: * enabled wiping for partitions * hint that disks recognized as OSDs should use the OSD destroy dialogue if possible (i.e., if that disk is actually an OSD in the current cluster and all is still healthy enough for that) * I'd change the top bar in general more like the OSD tree one, i.e., only reload left and the wipe/smart/init GPT buttons on the right with the selected disk text prefixed * The confirm dialogue feels like it could get still some improvement about how to convey what will be destroyed more nicely, but as I do not have concrete proposals I just mention it for the sake of it, maybe someone else has better ideas.