From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9E943717DF for <pve-devel@lists.proxmox.com>; Thu, 9 Sep 2021 14:29:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E2AC9DE5 for <pve-devel@lists.proxmox.com>; Thu, 9 Sep 2021 14:29:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0D30A9DDA for <pve-devel@lists.proxmox.com>; Thu, 9 Sep 2021 14:29:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D6219437A9; Thu, 9 Sep 2021 14:29:12 +0200 (CEST) Message-ID: <79abd2d8-3e4d-1b2f-0630-abbc5f5a4594@proxmox.com> Date: Thu, 9 Sep 2021 14:28:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Thunderbird/92.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com>, Lorenz Stechauner <l.stechauner@proxmox.com>, aderumier@odiso.com References: <20210906131542.178844-1-l.stechauner@proxmox.com> <20210906131542.178844-2-l.stechauner@proxmox.com> <c12b5e439e3dbdbcdf5061322a92e0e8d0408fdc.camel@odiso.com> <d3d7c2ef-a270-1001-b63c-278ad9d5668a@proxmox.com> <31f9f8d5-e356-65aa-9a9c-301c4d1f68c6@proxmox.com> <b7e0cac5-696e-e4fc-8bf0-5d0d98f395c6@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <b7e0cac5-696e-e4fc-8bf0-5d0d98f395c6@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 1.256 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.922 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage 1/1] fix #3580: plugins: make preallocation mode selectable for qcow2 and raw images X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 09 Sep 2021 12:29:43 -0000 On 09.09.21 14:04, Fabian Ebner wrote: > Am=C2=A009.09.21=C2=A0um=C2=A013:11=C2=A0schrieb=C2=A0Lorenz=C2=A0Stech= auner: >> >> On=C2=A009.09.21=C2=A012:25,=C2=A0Fabian=C2=A0Ebner=C2=A0wrote: >>> Am=C2=A008.09.21=C2=A0um=C2=A010:11=C2=A0schrieb=C2=A0alexandre=C2=A0= derumier: >>>> Hi, >>>> it=C2=A0can=C2=A0be=C2=A0done=C2=A0too=C2=A0with=C2=A0ceph=C2=A0rbd=C2= =A0with=C2=A0"rbd=C2=A0create=C2=A0...=C2=A0=E2=80=93thick-provision" >>>> >>> >>> Hi, >>> there also is the 'sparse' storage config option (currently only used= for ZFS plugins). If there is only thick or thin, re-using that one is p= robably nicer, because the newly proposed preallocation option seems to=C2= =A0be=C2=A0closely=C2=A0tied=C2=A0to=C2=A0qemu-img. >> >> Sounds like a good idea. I doubt, that anyone would use full prellocat= ion anyway, so simply using 'sparse' for prealloc=3Doff and default=C2=A0= remains=C2=A0prealloc=3Dmetadata=C2=A0sounds=C2=A0good. >> >=20 > I actually only meant re-using 'sparse' for the RBD use case. But yes, = it seems like re-using it for the qemu-img use case would be enough to fi= x the bug too. It might be a bit confusing though, because when sparse is= =C2=A0not=C2=A0set,=C2=A0the=C2=A0images=C2=A0would=C2=A0still=C2=A0be=C2= =A0mostly=C2=A0sparse=C2=A0(except=C2=A0for=C2=A0metadata). Yeah, I'm not sure that just deriving all from the sparse storage option = would be good UX - I think it should be per creation and if we want to expand t= he scope of such a value we should rather see it as fallback. But IMO this is a bit of an edge case anyway, so I'd not rush the latter = without user demand.