From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0AB131FF16F for <inbox@lore.proxmox.com>; Tue, 27 May 2025 11:12:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D87A4FA44; Tue, 27 May 2025 11:13:04 +0200 (CEST) Message-ID: <7936801f-49a9-4a89-99c8-5dba3e7b0343@proxmox.com> Date: Tue, 27 May 2025 11:13:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com References: <20240614112947.69555-1-f.ebner@proxmox.com> <20240614112947.69555-2-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20240614112947.69555-2-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH container] autocomplete: os templates: do not list VM backup archives for restore X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 14.06.24 um 13:29 schrieb Fiona Ebner: > While archives with unknown or undetermined subtype could be shown, > this is only for autocompletion, so users can still specify those > manually if required. > > Signed-off-by: Fiona Ebner <f.ebner@proxmox.com> > --- > src/PVE/LXC.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 65d0fa8..e154efe 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -2341,6 +2341,7 @@ sub complete_os_templates { > my $res = []; > foreach my $id (keys %$data) { > foreach my $item (@{$data->{$id}}) { > + next if $vtype eq 'backup' && ($item->{subtype} // '') ne 'lxc'; > push @$res, $item->{volid} if defined($item->{volid}); > } > } Ping regarding this one, still applies cleanly. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel