From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AB94D6B49C for ; Mon, 20 Sep 2021 12:31:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A57E1F28D for ; Mon, 20 Sep 2021 12:31:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D857D1F27F for ; Mon, 20 Sep 2021 12:31:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB51C449A4; Mon, 20 Sep 2021 12:31:09 +0200 (CEST) Message-ID: <787e0a59-91a1-3372-bd96-0f4f895181bc@proxmox.com> Date: Mon, 20 Sep 2021 12:30:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Xylle References: <20210919090927.15141-1-xylle@kidja.tf> <20210919090927.15141-2-xylle@kidja.tf> From: Thomas Lamprecht In-Reply-To: <20210919090927.15141-2-xylle@kidja.tf> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.255 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH dab 1/1] Add https support for download X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2021 10:31:40 -0000 On 19.09.21 11:09, Xylle wrote: > --- > DAB.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/DAB.pm b/DAB.pm > index 9282789..3c6b948 100644 > --- a/DAB.pm > +++ b/DAB.pm > @@ -517,7 +517,7 @@ sub new { > my $sources = undef; > > foreach my $s (@{$config->{source}}) { > - if ($s =~ m@^\s*((http|ftp)://\S+)\s+(\S+)((\s+(\S+))+)$@) { > + if ($s =~ m@^\s*((http|https|ftp)://\S+)\s+(\S+)((\s+(\S+))+)$@) { > my ($url, $su, $components) = ($1, $3, $4); > $su =~ s/SUITE/$suite/; > $components =~ s/^\s+//; > @@ -539,7 +539,7 @@ sub new { > } > > foreach my $m (@{$config->{mirror}}) { > - if ($m =~ m@^\s*((http|ftp)://\S+)\s*=>\s*((http|ftp)://\S+)\s*$@) { > + if ($m =~ m@^\s*((http|https|ftp)://\S+)\s*=>\s*((http|ftp)://\S+)\s*$@) { > my ($ms, $md) = ($1, $3); > my $found; > foreach my $ss (@$sources) { > thanks for your contribution, to be able to take that in we'd need to have: - A signed CLA sent to see the dev. wiki for details: https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright - The patch sent with a `Signed-off-by: Full Name ` tag, if the user/email is already configured for git, you can automatically add that by using the `-s` or `--signoff` CLI parameter on commit/format-patch or send-email command Also note that for a single patch a cover-letter is normally not required, and if added it should at least contain some text besides the "**BLURB**" template ;-) cheers, Thomas