From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7D2DB6E5DB for ; Tue, 24 Aug 2021 10:52:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 691472B3ED for ; Tue, 24 Aug 2021 10:52:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 947DF2B3E2 for ; Tue, 24 Aug 2021 10:52:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6AA8B437D9; Tue, 24 Aug 2021 10:52:10 +0200 (CEST) To: Proxmox VE development discussion , Thomas Lamprecht , alexandre derumier , Wolfgang Bumiller References: <20210810075511.37393-1-w.bumiller@proxmox.com> <71d62f433be447c0201e168f20934f351a210448.camel@odiso.com> From: Stefan Reiter Message-ID: <77baa662-936d-a9aa-0b8c-d292c9acc724@proxmox.com> Date: Tue, 24 Aug 2021 10:52:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.591 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.023 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH qemu] drop patch force-disabling smm X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 08:52:44 -0000 On 8/23/21 6:01 PM, Thomas Lamprecht wrote: > On 10/08/2021 15:47, alexandre derumier wrote: >> Le mardi 10 août 2021 à 09:55 +0200, Wolfgang Bumiller a écrit : >>> This drops debian/patches/pve/0005-PVE-Config-smm_available- >>> false.patch >>> (and renumbers the remaining patches) >>> >>> From what I could gather, this patch was originally added >>> due to issues with old kernels. Now we have users which >>> seem to run into issues *with* the patch. >> yes indeed, this was old kernel with some old processors. >> >> >> Just be carefull with live migration, I wonder if it's not breaking >> migration it you just remove it like that. >> (Maybe it could be better to remove it for qemu > 6.1, it should be >> tested) >> > > Did anybody tested this on live migration (on a system where it would > actually toggle to true)? I've tested live-migration in both directions (with patch <-> current), Linux and Windows guests on a nested setup (but SMM is emulated in QEMU so nested shouldn't matter AFAIU). All worked without issue. I'm not sure if there is something specific a guest would need to do to exercise SMM support, but since we're turning it on, not off, I'm pretty sure that at least forward migration should always work. Tested-by: Stefan Reiter > > If it breaks that we'd need to fallback to the old "false" with a QEMU > machine version check and we could only drop it then in PVE 8.0, so hopefully > it Just Works™ to safe that hassle.. > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >