From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 73B39864F for ; Mon, 21 Aug 2023 16:05:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 600F021D7 for ; Mon, 21 Aug 2023 16:05:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Aug 2023 16:05:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9DA8042D88 for ; Mon, 21 Aug 2023 16:05:19 +0200 (CEST) Message-ID: <774458cc-9687-21f0-3d27-4f943b3d5e62@proxmox.com> Date: Mon, 21 Aug 2023 16:05:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: Proxmox VE development discussion , Markus Frank References: <20230522100949.80363-1-m.frank@proxmox.com> <20230522100949.80363-2-m.frank@proxmox.com> From: Fiona Ebner In-Reply-To: <20230522100949.80363-2-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.279 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v9 1/5] enable VNC clipboard parameter in vga_fmt X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2023 14:05:20 -0000 This needs a rebase, but looks good to me other than a few nits. Am 22.05.23 um 12:09 schrieb Markus Frank: > added option to use the qemu vdagent implementation to enable the VNC > clipboard. When enabled with SPICE the spice-vdagent gets replaced with the qemu > implementation. > Nit: QEMU should be capitalized > This patch does not solve #1406, but does allow copy and paste with > a running X-session, when spice-vdagent is installed on the guest. > > added vnc-clipboard variable to return at status/current > Nit: This part could've been a separate patch > By that noVNC is able to check if clipboard is active. > > Signed-off-by: Markus Frank > --- (...) > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 40be44d..8d30f7c 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -193,8 +193,16 @@ my $vga_fmt = { > minimum => 4, > maximum => 512, > }, > + 'vnc-clipboard' => { > + description => "enable VNC clipboard (requires spice tools in the guest)", Nit: SPICE should be capitalized "SPICE guest tools" seems to be the name for Windows, should we say "SPICE guest tools/SPICE vdagent" instead? > + type => 'boolean', > + optional => 1, > + default => 0 > + } Style nit: missing trailing comma for the above two lines > }; > > +my $vnc_clipboard_regex = qr/^(std|cirrus|vmware|virtio|qxl)/; I'd slightly prefer a hash with all the valid keys instead of a regex, but no big deal.