From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BDEF71FF0AA for ; Tue, 20 Oct 2026 14:29:33 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 259C02171A; Tue, 20 Oct 2026 14:29:02 +0200 (CEST) Message-ID: <77119e52-f895-4a0b-b48a-42b0745276f8@proxmox.com> Date: Tue, 20 Oct 2026 14:28:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server 2/5] drive: update TPM size on creation To: Thomas Ellmenreich , pve-devel@lists.proxmox.com References: <20261019095346.175659-1-t.ellmenreich@proxmox.com> <20261019095346.175659-3-t.ellmenreich@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20261019095346.175659-3-t.ellmenreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792499337085 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.349 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5AR6SCVLF3BWQWKYOQFVSCRH3VQWWZDA X-Message-ID-Hash: 5AR6SCVLF3BWQWKYOQFVSCRH3VQWWZDA X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The commit subject should start out with "api: create disks:" Am 19.10.26 um 11:53 AM schrieb Thomas Ellmenreich: > When creating a TPM drive, the default size is 4MiB. This default is > constant and cannot be changed, unless the backing storage has a bigger > granularity, in which case it is forcibly changed to the bigger size. > > To directly show the correct size of a TPM drive, query its size after > creation, and set that as the drive size. > > Suggested-by: Fiona Ebner > Signed-off-by: Thomas Ellmenreich With the commit subject and nits addressed: Reviewed-by: Fiona Ebner > --- > src/PVE/API2/Qemu.pm | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm > index cfbc1f51..e42cad74 100644 > --- a/src/PVE/API2/Qemu.pm > +++ b/src/PVE/API2/Qemu.pm > @@ -665,13 +665,21 @@ my sub create_disks : prototype($$$$$$$$$$$) { > $storecfg, $storeid, $vmid, $fmt, $arch, $disk, $smm, $cvm_type, > ); > } elsif ($ds eq 'tpmstate0') { > - # A fixed size is used for TPM state volumes > - $size = PVE::Tools::convert_size( > + Style nit: blank line here is inconsistent with the surrounding style > + # A fixed size is requested for TPM state volumes, but the > + # storage might increase it up to its allocation granularity > + my $target_size = PVE::Tools::convert_size( > PVE::QemuServer::Drive::TPMSTATE_DISK_SIZE, > 'b' => 'kb', > ); > - $volid = > - PVE::Storage::vdisk_alloc($storecfg, $storeid, $vmid, $fmt, undef, $size); > + Style nit: I'd drop this blank too, since otherwise the first bit with the comment feels a bit detached > + $volid = PVE::Storage::vdisk_alloc( > + $storecfg, $storeid, $vmid, $fmt, undef, $target_size, > + ); > + $size = PVE::Tools::convert_size( > + PVE::QemuServer::get_tpmstate_size($volid, $storecfg), > + 'b' => 'kb', > + ); > } else { > $volid = > PVE::Storage::vdisk_alloc($storecfg, $storeid, $vmid, $fmt, undef, $size);