From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 94B85A2B61 for <pve-devel@lists.proxmox.com>; Tue, 20 Jun 2023 12:48:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6F16F33988 for <pve-devel@lists.proxmox.com>; Tue, 20 Jun 2023 12:48:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 20 Jun 2023 12:48:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 943AC41C12; Tue, 20 Jun 2023 12:48:53 +0200 (CEST) Message-ID: <76e33b7d-c564-29b0-d076-01fc01968322@proxmox.com> Date: Tue, 20 Jun 2023 12:48:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Aaron Lauterer <a.lauterer@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20230619141307.119430-1-d.csapak@proxmox.com> <20230619141307.119430-4-d.csapak@proxmox.com> <bad242d3-7a01-d063-6f08-9bc27c55cb7b@proxmox.com> <b11761e4-6327-3a40-4881-e8240811c9a4@proxmox.com> <23bab32a-abc9-52a4-e4b9-3f35c9c5547f@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <23bab32a-abc9-52a4-e4b9-3f35c9c5547f@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [RFC PATCH manager 4/4] ui: pci mapping: rework mapping panel for better user experience X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 20 Jun 2023 10:48:54 -0000 On 6/20/23 12:18, Aaron Lauterer wrote: > > > On 6/20/23 11:57, Dominik Csapak wrote: >> On 6/20/23 11:35, Aaron Lauterer wrote: >>> I like the approach as it cleans up the overloaded tbar that has items that are only valid in >>> certain contexts. >>> >>> Two small nits from a UX POV: >>> >>> - double clicking any PCI device should open the edit dialog for the node, similar to double >>> clicking the node itself >> >> makes sense imo >> >>> - the Action Column should probably be further left and not on the far right side by default. I >>> personally like it to be the second column from the left as all other columns are rather informal. >> >> mhmm can do that, but how i refactored that seems to be a bit hacky to inject an actioncolumn at a >> certain position, but technically not a problem > > But aren't we doing that already in the content view of PBS? AFAIK it is the 3rd column there. > > sorry i didn't describe it properly. ofc it's possible to have the actioncolumn at any position it's just that the way i have structured the code makes it slightly weird to do (the columns are defined in the subclasses, but the actioncolumn would be injected in the base class, so i'd have to split the columns array before inserting it)