From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 58BC6932B6 for ; Fri, 17 Feb 2023 17:39:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B8B28EE2 for ; Fri, 17 Feb 2023 17:38:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 17 Feb 2023 17:38:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D3E1B47810 for ; Fri, 17 Feb 2023 17:38:57 +0100 (CET) Message-ID: <76af9067-9481-975f-00ac-c8b5602036d6@proxmox.com> Date: Fri, 17 Feb 2023 17:38:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Wolfgang Bumiller , Christoph Heiss References: <20230215140245.496507-1-c.heiss@proxmox.com> <20230215140245.496507-4-c.heiss@proxmox.com> <20230217145103.sl2bgaoq5jtuskp6@fwblub> From: Thomas Lamprecht In-Reply-To: <20230217145103.sl2bgaoq5jtuskp6@fwblub> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.256 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 container 3/4] lxc: Add `link-down` config to allow setting interfaces as disconnected X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Feb 2023 16:39:29 -0000 Am 17/02/2023 um 15:51 schrieb Wolfgang Bumiller: >> * Rename option to kebap-case > Sorry I missed that when Thomas replied to the v1. > This is a case where the property already exists in the VM api, so > better reuse the snake_case version here. @Thomas? > I assumed that, that's why I asked if keeping it that way would help to reuse some code infra; not sure about how useful it is to keep it for API consumers to keep it the same as in a quite different API end point, but I see where you come from and don't insist for going with snake-case, so if you think using the same style here has benefits. we can ignore the guidance that new params should always use kebab-case. but as said off-list, a big s/_/-/ (and same for our camelCase usages -.-) for PVE 8.0 seems long overdue; then we can also add some style asserts in the api schema verifier to avoid reintroducing those things.