From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 16F92CF5F; Wed, 13 Apr 2022 11:44:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0BE7E20F07; Wed, 13 Apr 2022 11:43:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 917F620EFC; Wed, 13 Apr 2022 11:43:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 69B89419C5; Wed, 13 Apr 2022 11:43:56 +0200 (CEST) Message-ID: <7667de36-4f88-b5c9-0bc1-71efbd658821@proxmox.com> Date: Wed, 13 Apr 2022 11:43:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Stefan Sterz , pve-devel@lists.proxmox.com References: <20220412103423.3845322-1-s.sterz@proxmox.com> <20220412103423.3845322-3-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220412103423.3845322-3-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [pbs-devel] [PATCH widget-toolkit v5 2/5] toolkit: add NotesView panel and NotesEdit window X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2022 09:44:27 -0000 On 12.04.22 12:34, Stefan Sterz wrote: > move them here from pve so we can maintain them across several > products > > Signed-off-by: Stefan Sterz > --- > src/Makefile | 2 + > src/panel/NotesView.js | 129 ++++++++++++++++++++++++++++++++++++++++ > src/window/NotesEdit.js | 38 ++++++++++++ > 3 files changed, 169 insertions(+) > create mode 100644 src/panel/NotesView.js > create mode 100644 src/window/NotesEdit.js > > applied, thanks! It seems that I have wrongly conveyed that the 1:1 + changes in a separate patch means a literal 1:1, changes that are required to avoid breakage (e.g., due to redefinition of existing source classes) should be still avoided. So it's more like "move 1:1 as closely as possible without breaking the build and/or product). Anyhow, no biggie, so I just moved the class/xtypes renames into widget-toolkit patch 1 and noted in the commit message that I did so.