From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F07BD916E4 for ; Thu, 8 Sep 2022 17:31:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF03E1E4C7 for ; Thu, 8 Sep 2022 17:31:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 8 Sep 2022 17:31:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 103BA42D8F for ; Thu, 8 Sep 2022 17:31:04 +0200 (CEST) Message-ID: <76618562-4ba2-ae3e-5f69-646db6978d77@proxmox.com> Date: Thu, 8 Sep 2022 17:31:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20220908095550.2913416-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220908095550.2913416-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.248 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied-series: [PATCH proxmox-login-manager/pve-flutter-frontend] fixes & update to flutter 3.3 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2022 15:31:09 -0000 Am 08/09/2022 um 11:55 schrieb Dominik Csapak: > updates to the code for flutter 3.3 and includes some fixes & improvements > > i included aarons patches from december to make it easier to apply > > the changes necesseary for flutter 3.3 are > proxmox-login-manager: 2/3 > pve-flutter-frontend: 2/10 - 6/10 > > patches after that are only fixes & improvements > (so stricly not necessary for flutter 3.3) > > i noticed some other things too, but for now this should be ok: > e.g. we have quite some widgets/code that are not in use currently > (from tims desktop variant AFAIR), maybe we should remove them > for now (or move it to another repo if we want to use them) > since then we could better use 'flutter analyze' > (now these widgets/files make much noise to the point where it's hard > to see which warnings/infos are even relevant for the app) > I'd like to have a layout for desktop/tablets with a always visible, resoure-tree like panel at the side, but no high priority for such things and some widgets may be deleted nonetheless. > proxmox-login-manager: > > Aaron Lauterer (1): > login_form: keep Continue button above Android softnav > > Dominik Csapak (2): > migrate from FlatButton to TextButton > improve colors of login screen > > lib/proxmox_login_form.dart | 288 +++++++++++++++++++----------------- > lib/proxmox_tfa_form.dart | 11 +- > 2 files changed, 156 insertions(+), 143 deletions(-) > > pve-flutter-frontend: > > Aaron Lauterer (1): > avoid elements hiding behind Android softnav buttons > > Dominik Csapak (9): > increase compileSdkVersion to 32 > fix null handling in MainActivity.kt > move to OutlinedButton from OutlineButton > move to TextButton from FlatButton > move to ElevatedButton from RaisedButton > improve colors for indicator/toggles > fix typo Opague -> Opaque > fix guest backup widget start display > fix options view when ostype is null > > android/app/build.gradle | 2 +- > .../app/pve_flutter_frontend/MainActivity.kt | 2 +- > lib/main.dart | 14 + > lib/pages/main_layout_slim.dart | 2 +- > .../firstWelcomeScreen/pve_welcome_faq.dart | 10 +- > .../firstWelcomeScreen/pve_welcome_last.dart | 26 +- > lib/widgets/pve_cd_selector_widget.dart | 7 +- > lib/widgets/pve_console_menu_widget.dart | 4 +- > lib/widgets/pve_first_welcome_screen.dart | 32 +- > lib/widgets/pve_guest_backup_widget.dart | 157 ++++----- > lib/widgets/pve_lxc_options_widget.dart | 140 ++++---- > lib/widgets/pve_main_navigation_drawer.dart | 4 +- > lib/widgets/pve_qemu_options_widget.dart | 259 +++++++------- > lib/widgets/pve_qemu_overview.dart | 319 +++++++++--------- > .../pve_qemu_power_settings_widget.dart | 178 +++++----- > .../pve_subscription_alert_dialog.dart | 2 +- > .../pve_task_log_expansiontile_widget.dart | 4 +- > 17 files changed, 602 insertions(+), 560 deletions(-) > applied, thanks!