From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 504E1939B8
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 13:00:56 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 3335F16F1
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 13:00:56 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 13:00:55 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1F86543341
for <pve-devel@lists.proxmox.com>; Mon, 19 Sep 2022 13:00:55 +0200 (CEST)
Message-ID: <765748c9-d21f-68c7-e6c4-8406cf0bbccd@proxmox.com>
Date: Mon, 19 Sep 2022 13:00:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101
Thunderbird/105.0
Content-Language: en-GB
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
References: <20220919091621.29538-1-f.ebner@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220919091621.29538-1-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 1.811 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -3.657 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add
"Installation media" label when in wizard
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 19 Sep 2022 11:00:56 -0000
On 19/09/2022 11:16, Fiona Ebner wrote:
> People sometimes expect to select the storage for the VM's disk first.
> This should make the context clearer.
>
> Suggested in the community forum:
> https://forum.proxmox.com/threads/75219/post-498758
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> www/manager6/qemu/CDEdit.js | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/www/manager6/qemu/CDEdit.js b/www/manager6/qemu/CDEdit.js
> index fc7a59cc..f409fa53 100644
> --- a/www/manager6/qemu/CDEdit.js
> +++ b/www/manager6/qemu/CDEdit.js
> @@ -76,6 +76,13 @@ Ext.define('PVE.qemu.CDInputPanel', {
> items.push(me.bussel);
> }
>
> + if (me.insideWizard) {
> + items.push({
> + xtype: 'displayfield',
> + value: `${gettext('Installation media')}:`,
> + });
> + }
> +
> items.push({
> xtype: 'radiofield',
> name: 'mediaType',
Bit torn on this one, otoh it's small and might help some, otoh I think that
it shouldn't be required - there's OS in the tab title already and a disk tab
two steps ahead, that paired with the fact that there's clearly written "CD/DVD
drive" so it should be pretty easy to understand, and if not that extra hint
isn't probably adding that much of extra info over the existing cues, also note,
and here I'm probably over analysing/nit-picking, but it doesn't necesarrily
needs to be a installation media, e.g. for a live distro.
The heading fits somewhat with the one from the OS type selector, so from a purely
layout POV it would be fine to have. Maybe just some other wording, like a plain/
technical "Virtual CD/DVD Drive".
Anyhow, I just take such "just add yet another cue and it would be 101% straight
forward for anybody" like things rather with a grain of salt, as there def. are
quite some existing cues and such proposal are quite subjective (like the "just
that single feature and project XYZ will be Just Perfect™), need to let this ripe
a bit, maybe I'll merge it as is (that is, if you don't send another v2 due to some
agreement here in my ramblings or another, better idea)