From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 279FB1FF170 for ; Tue, 19 Nov 2024 10:41:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D37351E2F2; Tue, 19 Nov 2024 10:41:35 +0100 (CET) Message-ID: <760bb5c6-459c-425d-829a-0c63afe6896f@proxmox.com> Date: Tue, 19 Nov 2024 10:41:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht , Proxmox VE development discussion References: <20241119092224.785853-1-d.csapak@proxmox.com> <491a7dbc-9b2e-46d5-9f09-f4878e140854@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: resource tree: add collapse/expand all button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/19/24 10:39, Thomas Lamprecht wrote: > Am 19.11.24 um 10:36 schrieb Dominik Csapak: >> On 11/19/24 10:30, Thomas Lamprecht wrote: >>> Am 19.11.24 um 10:22 schrieb Dominik Csapak: >>>> which defaults to expand all, and only if all expanded, collapse all. >>>> >>>> Changes icon dynamically when nodes expand/collapse. >>>> >>>> Signed-off-by: Dominik Csapak >>>> --- >>>> if we'd find an icon that would fit for both cases, we could omit the >>>> event bubbling probably. If there are many nodes, the 'hasCollapsed' >>>> check will trigger more often, iterating over all tree nodes.. >>> >>> We could also just do two separate buttons, FWIW. >> >> true, but the space there is already a bit limited IMO, and > > it's just two icons and the view selector is mostly empty space as the entries > are all relatively short > >> only one of the buttons makes sense at one point in time >> > > That's not completely true, if I got a few nodes expanded and a few nodes > closed then having both allows to avoid an extra click and some potential UX > confusion. true, i'll send a v2 with two buttons, icons are ok for you or do you have a different sugggestion? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel