From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8EB951FF179 for ; Wed, 10 Dec 2025 20:32:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E83A943B5; Wed, 10 Dec 2025 20:33:00 +0100 (CET) Message-ID: <75e3217f-8359-4e24-a992-fe09318f12c8@proxmox.com> Date: Wed, 10 Dec 2025 20:32:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Stefan Hanreich References: <20251210184236.448600-1-s.hanreich@proxmox.com> <20251210184236.448600-5-s.hanreich@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251210184236.448600-5-s.hanreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765395139212 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-network 1/1] fix #6806: vlan: qinq: fix bridge port detection X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 10.12.25 um 19:43 schrieb Stefan Hanreich: > When creating a vlan zone and vnet, pve-network looks at all the > physical bridge ports (slaves) and adds them to the generated vlan > bridge. The zone plugin gets all the bridge interfaces using > `/sys/class/net` and then filters them using a regex. With the > introduction of network interface pinning, the restrictions on network > interface names have gotten more liberal - they're not required to > have specific prefixes anymore. The check for physical interfaces in > the zones plugin needs to be adjusted to reflect those changes, > otherwise the generated SDN configuration does not contain any pinned > physical ports and therefore doesn't work. Use the provided helper > from PVE::IPRoute2 instead, that adheres to the new naming policy and > uses `ip link` to determine the physical ports of the bridge, instead > of relying on a regex. > > This improves the previous commit 4f19480b - which only allowed the > nic / if prefixes, which solved the issue when using the default > prefix, but not when using a custom prefix. > > Fixes: 4f19480b04315afb5dc23e0130463acaea35db18 > Signed-off-by: Stefan Hanreich > --- > src/PVE/Network/SDN/Zones/Plugin.pm | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel