From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 150351FF0AA
	for <inbox@lore.proxmox.com>; Tue, 03 Nov 2026 17:31:08 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 3C59621321;
	Tue, 03 Nov 2026 17:31:05 +0100 (CET)
Message-ID: <7583a62e-5d81-4f48-9cd7-e395dd97305f@proxmox.com>
Date: Tue, 3 Nov 2026 17:31:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH pve-storage v3 01/19] plugin: add efi-firmware content
 type
To: Christian Ludwig <christian_ludwig@genua.de>, pve-devel@lists.proxmox.com
References: <cover.1793029144.git@genua.de>
 <01c34eb1dde147435381239f92e2a0fcccfcffbe.1793029144.git@genua.de>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: 
 <01c34eb1dde147435381239f92e2a0fcccfcffbe.1793029144.git@genua.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793723461352
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.299 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: F5LWIW73C2HBIONYYXSFVGSFZ6VFYZVP
X-Message-ID-Hash: F5LWIW73C2HBIONYYXSFVGSFZ6VFYZVP
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 27.10.26 um 11:12 AM schrieb Christian Ludwig:
> @@ -1855,6 +1860,12 @@ my $get_subdir_files = sub {

Nit: The comment above the function should also mention efi-firmware

>                  m!/(${PVE::Storage::SAFE_CHAR_CLASS_RE}+$PVE::Storage::IMPORT_EXT_RE_1)$!i;
>  
>              $info = { volid => "$sid:import/$1", format => "$2" };
> +        } elsif ($tt eq 'efi-firmware') {
> +            next
> +                if $fn !~
> +                m!/(${PVE::Storage::SAFE_CHAR_CLASS_RE}+$PVE::Storage::EFI_FIRMWARE_EXT_RE_1)$!;
> +
> +            $info = { volid => "$sid:efi-firmware/$1", format => 'raw' };
>          }
>  
>          $info->{size} = $st->size;