From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 206B38C795
 for <pve-devel@lists.proxmox.com>; Wed,  2 Nov 2022 13:24:53 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 01DE123666
 for <pve-devel@lists.proxmox.com>; Wed,  2 Nov 2022 13:24:53 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Wed,  2 Nov 2022 13:24:51 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8E08A44CEF
 for <pve-devel@lists.proxmox.com>; Wed,  2 Nov 2022 13:24:51 +0100 (CET)
Message-ID: <752e44ea-4039-4731-54a8-c7b3c9ddb1bf@proxmox.com>
Date: Wed, 2 Nov 2022 13:24:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Content-Language: en-US
To: pve-devel@lists.proxmox.com
References: <20221007124156.110246-1-f.ebner@proxmox.com>
 <20221007124156.110246-19-f.ebner@proxmox.com>
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20221007124156.110246-19-f.ebner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.028 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [pvestatd.pm]
Subject: Re: [pve-devel] [PATCH v2 manager 4/5] cluster resources: add
 cgroup-mode to node properties
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 02 Nov 2022 12:24:53 -0000

> diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
> index eac953df..61de8b36 100755
> --- a/PVE/Service/pvestatd.pm
> +++ b/PVE/Service/pvestatd.pm
> @@ -123,9 +123,25 @@ my $generate_rrd_string = sub {
>      return join(':', map { $_ // 'U' } @$data);
>  };
>  
> +my sub broadcast_cgroup_mode {
> +    my $cgroup_mode = eval { PVE::CGroup::cgroup_mode(); };
> +    if (my $err = $@) {
> +	syslog('err', "cgroup mode error: $err");
> +	return;
> +    }
> +
> +    my $old = PVE::Cluster::get_node_kv("cgroup-mode", $cgroup_mode, $nodename);

The second parameter here is wrong, sorry!

Since the static node information like CPU core count and total memory
is intended to be similarly broadcast, it might even be better to
generalize the kv entry to "static-info", which includes cgroup mode as
well as CPU+memory info.