From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 210CF7A4FD for ; Mon, 4 Jul 2022 10:57:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 18ED624A23 for ; Mon, 4 Jul 2022 10:57:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 4 Jul 2022 10:57:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6A21940EE9 for ; Mon, 4 Jul 2022 10:57:57 +0200 (CEST) Message-ID: <75071162-a918-df16-6fd2-3434bff42e39@proxmox.com> Date: Mon, 4 Jul 2022 10:57:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20220506101114.45522-1-f.ebner@proxmox.com> <918c79831c6396b610b9bc302564f062f3566385.camel@groupe-cyllene.com> From: Mira Limbeck In-Reply-To: <918c79831c6396b610b9bc302564f062f3566385.camel@groupe-cyllene.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.318 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [RFC qemu-server] api: create disks: avoid adding secondary cloud-init drives X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jul 2022 08:57:58 -0000 On 5/16/22 13:04, DERUMIER, Alexandre wrote: > Le vendredi 06 mai 2022 à 12:11 +0200, Fabian Ebner a écrit : >> This will break possibly existing workflows like >> 1. add second cloud-init >> 2. remove first cloud-init >> to change the cloud-init storage. > Also, currently, in the gui, we can't add 2 cloud-init drives > currently. > > But we could add an "move disk" like feature. > generate current cloudinit config on a new drive and swap isos online. > (If iso is mounted in the guest os, it's not a problem, as it's > readonly, and the mountpoint content is updated too) > `Move Disk` while the VM is running, should not recreate the disk from config as this could lead to a changed cloud-init disk. Offline should be fine, but online `Move Disk` must re-use the current cloud-init disk. We had the same issue in the live migration case. We now offline migrate the cloud-init disk and pass an argument during start on the target node to skip generating the cloud-init disk as a workaround. Live migration the same way all other disks are migrated doesn't work here because the cloud-init disk is readonly mounted in QEMU.