From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BF3448C9FE; Fri, 4 Nov 2022 09:44:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A127F37CFF; Fri, 4 Nov 2022 09:44:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Fri, 4 Nov 2022 09:44:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E36B343ECA; Fri, 4 Nov 2022 09:44:24 +0100 (CET) Message-ID: <74bb2044-3770-e75f-3d13-fa5154330979@proxmox.com> Date: Fri, 4 Nov 2022 09:44:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Content-Language: en-US From: Fiona Ebner To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com References: <20220720105948.291740-1-f.ebner@proxmox.com> <20220720105948.291740-4-f.ebner@proxmox.com> In-Reply-To: <20220720105948.291740-4-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.122 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [pmg-devel] [PATCH pve-common 3/5] pbs client: default to configured namespace for non-namespaced parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2022 08:44:55 -0000 Am 20.07.22 um 12:59 schrieb Fabian Ebner: > For get_snapshots(), also set the default when no namespaced parameter > is present at all. > > This would break any callers that have a namespace in the initial > config and explicitly don't set it for a later call, but the only > such caller is restore_pxar() in PMG, which /should/ be using the > namespace! > > In other words, this implicitly fixes the restore_pxar() call in PMG > and avoids the need to extract the namespace from the configuration > (which already is present in the client) on the call site for all > functions that currently take a namespaced parameter. > > Signed-off-by: Fabian Ebner Ping. I feel like making restoring backups from namespaces work would be nice to have for the next PMG release (even if there are no actual user reports about the issue yet AFAIK).